1738669 - Unable to create a new "Saved Search Folder" using "Save View as a Folder..."

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Nuno Silva [:njsg]]

In Mail&News, the "Save View as a Folder" option in the "View" drop-down (top left, below the button bar) does not work, and leaves the following error in the error console:

Error: ReferenceError: aSearchTems is not defined
Source File: chrome://messenger/content/folderPane.js

Changing that to aSearchTerms makes this option work.

Comment 1

[Nuno Silva [:njsg]]

Attachment: 1738669-aSearchTerm-v1.patch

Comment 2

[Nuno Silva [:njsg]]

(This also affects File->New->"Saved Search...")

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1738669-aSearchTerm-25310.patch

Reformatted hg patch

lgtm r/a+

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1738669-termsArray-25310.patch

Even with the first patch the view is not updated correctly. View->Messages->Custom Views-><pick one from the list> results in a blank list because termsArray.length is undefined.

This patch is only needed for 2.53 and 2.57 because Bug 1681009 fixed it for comm-central.

[Approval Request Comment]
Regression caused by (bug #): Bug 857230
User impact if declined: virtual folder views do not work
Testing completed (on m-c, etc.): 2.53.11b1 pre
Risk to taking this patch (and alternatives if risky): broken already.
String changes made by this patch: none

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1738669-termsArray-v1_1-25310.patch

Updated patch. Removed unneeded weak parameter because Bug 1313150 is in 2.53.

Even with the first patch the view is not updated correctly. View->Messages->Custom Views-><pick one from the list> results in a blank list because termsArray.length is undefined.

This patch is only needed for 2.53 and 2.57 because Bug 1681009 fixed it for comm-central.

[Approval Request Comment]
Regression caused by (bug #): Bug 857230
User impact if declined: virtual folder views do not work
Testing completed (on m-c, etc.): 2.53.11b1 pre
Risk to taking this patch (and alternatives if risky): broken already.
String changes made by this patch: none

Comment 6

[Ian Neal]

Comment on attachment 9249595 [details] [diff] [review]
1738669-termsArray-v1_1-25310.patch

[Triage Comment]
Instead of virtualFolderSearchTerm you could just use searchTerm then you won't need to change the appendElement line.

r/a=me either way

Comment 7

[Frank-Rainer Grahl (:frg)]

Attachment: 1738669-termsArray-cc.patch

As discussed via irc. Part 2 is technically not needed for comm-central but rename searchTerm to virtualFolderSearchTerm for consistency.

r=me because trivial.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e528f8fa5e77
Correct typo in folderPane.js. r=frg
https://hg.mozilla.org/comm-central/rev/abc7fdc37ebd
Rename searchTerm to virtualFolderSearchTerm for consistency. r=me

Comment 9

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/89deb0d94a48b7945fc3fd96567c66ceeb1fbfb1
Correct typo in folderPane.js. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/9dee4e90c7dbba4280e94f39b75b1f97da7d3b8f
Loop thru virtual folder searchterms using an iterator. r=IanN a=IanN