Closed Bug 1738714 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31456 - [css-position] Fix centering of <button> elements with auto margins.

Categories

(Core :: Layout: Positioned, task, P4)

Product:
Core
Component:
Layout: Positioned
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31456 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31456
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[css-position] Fix centering of <button> elements with auto margins.

Previously if an element was shrink-to-fit by default (tables, buttons,
etc), we'd fall into a branch where we didn't consider auto margins.

This resulted in elements not correctly centering.

This patch makes shrink-to-fit elements fall down the same branch as-if
we had a size specified.

Bug: 1236657
Change-Id: Id7dddc698d23c21740db717a524ceaaaadb71e98
Reviewed-on: https://chromium-review.googlesource.com/3253437
WPT-Export-Revision: 1f55368b9057f0780605dfe3edf860611679b80d

Component: web-platform-tests → Layout: Positioned
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 2
FAIL: 1

Chrome

FAIL: 3

Safari

PASS: 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-position/position-absolute-center-007.html: FAIL (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84aa5c818aa3 [wpt PR 31456] - [css-position] Fix centering of OOF <button> elements with auto margins., a=testonly https://hg.mozilla.org/integration/autoland/rev/9aa449c004cd [wpt PR 31456] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/84aa5c818aa3
https://hg.mozilla.org/mozilla-central/rev/9aa449c004cd

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.