1738829 - [wpt-sync] Sync PR 31446 - Fix DCHECK in editor FindString command

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31446 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31446
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Fix DCHECK in editor FindString command

This bug and fix is very similar to crbug.com/1251072. I made the same
fix as that bug, I didn't know that there was another place in editing
that could run Editor::FindString like window.find() does for the
mentioned bug.

I verified that this change fixes the clusterfuzz test case, and I also
added a similar test case to the one I added in crbug.com/1251072.

Fixed: 1264507
Change-Id: I24067700444d9a0ea79211c4324845d453fc9d89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253512
Reviewed-by: vmpstr \<[e-mail]>
Commit-Queue: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#937186}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=46d26af26807b117dd991a4994977c6016983a16

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e5376cb08c1
[wpt PR 31446] - Fix DCHECK in editor FindString command, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4e5376cb08c1