1738954 - LoginHelper(Content): "Couldn't parse origin for" "data:text/html,<input type=password>" ({})

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P3)

Description

[Mats Palmgren (inactive)]

STR

1. run firefox -layoutdebug
2. load data:text/html,<input type=password>
3. type something in the password control

ACTUAL RESULTS
console.warn: LoginHelper(Content): "Couldn't parse origin for" "data:text/html,<input type=password>" ({})
JavaScript error: resource://gre/modules/LoginAutoComplete.jsm, line 536: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.host]

Comment 1

[Sergey Galich [:serg]]

We would like to skip log.warn() here for this particular scenario.

Comment 2

[gloriaeskor]

Hello, I am an outreachy applicant. I read through the description and I do now understand what you need to be done. Can you kindly please explain the error and what needs to be done.

Comment 3

[gloriaeskor]

And I use windows, Can I still work on this?

Comment 4

[Sergey Galich [:serg]]

:gloriaeskor, sure, please give it a try!

I can reproduce it by opening Browser Console (Ctrl+Shift+J) and tab with data:text/html,<input type=password> in address line. When I type anything in the password box on that page, console gets a lot of warning messages. We do not want to call log.warn() when origin is data: scheme. No changes in logic, just reduce spam in logs.

Comment 5

[gloriaeskor]

Attachment: Bug 1738954 - Resolve "parse origin" error for "data:text/html,<input type=password>. r?sgalich

Comment 6

[gloriaeskor]

Attachment: Bug 1738954 - Resolve "parse origin" error for "data:text/html,<input type=password>. r?sgalich.

Depends on D130443

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 8

[Favour]

Please boss can i be assigned the bug?
Thank you...

Comment 9

[Ayesha Solanki]

Hi, I'm Ayesha Solanki, an Outreachy applicant. I would like to contribute on this issue. Can you assign it to me?

Comment 10

[Ekene Nwobodo]

How can I reproduce this error, I have opened the console with what is mentioned above. How can I tab to data:text/html,<input type=password>

Comment 11

[Ekene Nwobodo]

Attachment: Bug 1738954 - Resolve console warning 'Couldn't parse origin for: data:text/html,<input type=password>' ({}). r?sgalich

Comment 12

[Sergey Galich [:serg]]

(In reply to Ekene Nwobodo from comment #10)

How can I reproduce this error, I have opened the console with what is mentioned above. How can I tab to data:text/html,<input type=password>

Ekene, you can paste that data:text/html,<input type=password> in address bar.

Comment 13

[Ekene Nwobodo]

(In reply to Sergey Galich [:serg] from comment #12)

(In reply to Ekene Nwobodo from comment #10)

How can I reproduce this error, I have opened the console with what is mentioned above. How can I tab to data:text/html,<input type=password>

Ekene, you can paste that data:text/html,<input type=password> in address bar.

Hello Sergey,
I want to check in because my PR hasn't be reviewed.

Comment 14

[Ekene Nwobodo]

(In reply to Ekene Nwobodo from comment #13)

(In reply to Sergey Galich [:serg] from comment #12)

(In reply to Ekene Nwobodo from comment #10)

How can I reproduce this error, I have opened the console with what is mentioned above. How can I tab to data:text/html,<input type=password>

Ekene, you can paste that data:text/html,<input type=password> in address bar.

Comment 15

[Sergey Galich [:serg]]

(In reply to Ekene Nwobodo from comment #13)

I want to check in because my PR hasn't be reviewed.

Review happens in Phabricator, all comments are there, they won't appear on Bugzilla.

Comment 16

[Ekene Nwobodo]

(In reply to Sergey Galich [:serg] from comment #15)

(In reply to Ekene Nwobodo from comment #13)

I want to check in because my PR hasn't be reviewed.

Review happens in Phabricator, all comments are there, they won't appear on Bugzilla.

Patch has been updated

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5eb9fc85da10
Resolve console warning 'Couldn't parse origin for: data:text/html,<input type=password>' ({}). r=sgalich

Comment 18

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5eb9fc85da10