Closed
Bug 17392
Opened 25 years ago
Closed 2 months ago
needlessly creating nsMsgMailSession while running editor
Categories
(Core :: DOM: Editor, defect, P3)
Tracking
()
RESOLVED
INVALID
Future
People
(Reporter: warrensomebody, Unassigned)
References
Details
(Whiteboard: [platform-rel-Google] [platform-rel-Gmail])
Akkana Peck did this: setenv XPCOM_MEM_BLOAT_LOG 1 script apprunner -edit (typed a few characters, did Debug->Output HTML, then quit) ^D (to end the script) and said: Why do we create a nsMsgMailSession? We're not leaking it, but it seems strange that we have it at all. Scott, can you investigate? [PTD team: we don't know the extent of the memory bloat due to this yet. We just know it's unnecessary.]
Updated•25 years ago
|
Assignee: mscott → putterman
Comment 1•25 years ago
|
||
Scott, I was planning on removing this code once dp had his xpcom shutdown observer stuff cooking. The mail session should be a listener on the xpcom shutdown call and then we can write out the folder cache. That should allow us to take out the offending code from the bootstrap code. I thought this was pretty low priority and haven't bothered looking into doing that yet. I just read in a posting that you've also looked at this and that you were planning on fixing it. Re-assigning to you =).
Comment 2•25 years ago
|
||
For everyone's info, Bug 17712 talks about the changes that are going to be made to get shutdown working correctly in mailnews.
Comment 3•25 years ago
|
||
this no longer has anything to do with the bootstrap code. That's all been fixed. Now the problem is that we are saving off mail uris in localStore.rdf and when rdf reads it in it creates a mail resource. This will go away when we fix the way resources work.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M13
Updated•25 years ago
|
Target Milestone: M13 → M14
Comment 4•25 years ago
|
||
m14
Comment 5•25 years ago
|
||
M16. Changing the way resources work is too scary for B1
Target Milestone: M14 → M16
Reporter | ||
Comment 6•25 years ago
|
||
What is the "way resources work", and if this is scary now, will it be less-so in M16?
Comment 7•25 years ago
|
||
It'll be scary whenever I do it :) Right now mail objects can be QI'd into RDFResources and vice-versa. This dependency causes problems such as this bug. Waterson did some work a while ago that would let me remove this dependency but it will touch a lot of code in mailnews and is pretty risky. It will always be this way, but I don't think now is the right time to do it since it doesn't cause any major bugs.
Updated•24 years ago
|
Target Milestone: M16 → M18
Comment 8•24 years ago
|
||
moving to future milestone. I'm not changing the way mail resources work in this release.
Target Milestone: M18 → Future
Comment 9•24 years ago
|
||
nominating mail3 and reassigning to sspitzer.
Comment 10•24 years ago
|
||
removing nomination and marking as dependent on 20222. I'm 99% sure this will get fixed if 20222 is fixed.
Comment 11•24 years ago
|
||
Any progress on this?
Comment 12•20 years ago
|
||
Any progress on this yet?
Comment 13•20 years ago
|
||
thank you for volunteering, please build and run the tests in comment 0 and report back. you can skip |script|, and read |apprunner| as |mozilla|.
Assignee: sspitzer → warpozio
Comment 14•18 years ago
|
||
putterman in comment #10: > removing nomination and marking as dependent on 20222. I'm 99% sure this will > get fixed if 20222 is fixed. bug 20222 got duped to bug 211804, which I can't set as a blocker. 211804 is about ?_____?
Updated•17 years ago
|
QA Contact: sujay → editor
Comment 15•16 years ago
|
||
part of the shutdown story? I can't see bug 211804 except one would guess it's about RDF, so that's it for me.
Comment 16•16 years ago
|
||
when we stop using rdf, then, this should go away, though we might have to do something to insure that localstore.rdf is cleared, or not loaded.
Updated•8 years ago
|
Whiteboard: [platform-rel-Google] [platform-rel-Gmail]
Updated•8 years ago
|
platform-rel: --- → ?
Updated•7 years ago
|
platform-rel: ? → ---
Comment 17•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: warpozio → nobody
Updated•2 years ago
|
Severity: normal → S3
Comment 18•2 months ago
|
||
nsMsgMailSession is no longer in our editor code.
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•