1739357 - 0.09 - 0.07% installer size / installer size (OSX) regression on Tue November 2 2021

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Andra Esanu (needinfo me)]

Perfherder has detected a build_metrics performance regression from push 36619d5ef1e0b1b6de68ef1b4fd97b163775ccb6. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.09%	installer size	osx-shippable	instrumented	115,519,948.56 -> 115,626,740.42
0.07%	installer size	osx-shippable	instrumented	115,526,501.75 -> 115,609,571.67

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1739357 - Merge branches in some ComputedValues functions. r=#style,#layout-reviewers

This should mitigate the code size impact. Also make get_resolved_value
non-generic to avoid monomorphizing it multiple times.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2789931125b1
Merge branches in some ComputedValues functions. r=boris

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2789931125b1