1739522 - Focus issues when Clear button is enabled for <input type=search>

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P4)

Description

[Mats Palmgren (inactive)]

I noticed some focus issues when implementing the Show Password button for <input type=password> in bug 502258. The same issue also occurs with the Clear button in <input type=search>.

When you click the button the <input> element loses focus (it's now on the button so you can't type text into the control).
I fixed it for the Show Password button like so:
https://phabricator.services.mozilla.com/D130407#inline-716301

Comment 2

[Tim Giles [:tgiles]]

Attachment: Bug 1739522 - Prevent losing focus on clear search and password reveal buttons. r=emilio,#accessibility-frontend-reviewers

While it would be more beneficial if we didn't blur and focus the input
twice when clicking the clear search button, this is an improvement
over losing focus entirely.

I'm not entirely sure if the :focus / :focus-visible inconsistent
state issue is fixed by this change.

Depends on D243386

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11f55b37b32b
Prevent losing focus on clear search and password reveal buttons. r=emilio,accessibility-frontend-reviewers,ayeddi

Comment 4

[Atila Butkovits]

Backed out for causing mass failures

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/6b23657736ddb2d690612ab7801486006259c0eb

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=11f55b37b32bce47eb94e9e18a18ab51735332b1

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=505050094&repo=autoland&lineNumber=4274
https://treeherder.mozilla.org/logviewer?job_id=505050099&repo=autoland&lineNumber=2775
https://treeherder.mozilla.org/logviewer?job_id=505052681&repo=autoland&lineNumber=9008
https://treeherder.mozilla.org/logviewer?job_id=505050754&repo=autoland&lineNumber=1969

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f83d6aa646cb
Prevent losing focus on clear search and password reveal buttons. r=emilio,accessibility-frontend-reviewers,ayeddi

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f83d6aa646cb