Cache isn't updated when text attributes change
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
People
(Reporter: Jamie, Unassigned)
References
Details
Bug 1730096 implemented support for caching text attributes. However, if text attributes are updated on a container, the cache isn't updated accordingly. We need to get notified about such updates and push the cache when they occur.
Morgan noted that there is a nsIFrame::DidSetComputedStyle we can probably tweak to get notifications. (I think that's the function she meant. :) )
One thing to note is that I think style changes we care about often (always?) cause text to be reflowed. In that case, I think we're going to get text change notifications as well, where we already push the cache. We'll need to ensure we don't end up with redundant pushes as a result. For example, we might add code to prevent the text update push if the text string hasn't changed.
|
Reporter | |
Comment 2•7 months ago
|
||
We should be able to use LocalAccessible::MaybeQueueCacheUpdateForStyleChanges for this.
Bug 1908275 suggests we don't reflow, at least for colour changes. We'll need to look into which changes we handle correctly already and which ones we don't.
I'm marking this s3 because it doesn't appear to have impacted anyone in over a year, but it's probably bordering on an s2 for some users and use cases such as web or document authoring.
Description
•