1739677 - "IPDLParamTraits.h(41,26): error: no member named 'Write' in 'IPC::ParamTraits<mozilla::dom::quota::FullOriginMetadata>'" build bustage with --disable-accessibility

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Confirmed via bisection and local backout that this was caused by bug 1734649.

https://treeherder.mozilla.org/logviewer?job_id=357150451&repo=try&lineNumber=25250

In file included from UnifiedProtocols24.cpp:2:
In file included from /builds/worker/workspace/obj-build/ipc/ipdl/PQuotaRequest.cpp:18:
In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/ipc/ShmemMessageUtils.h:11:
/builds/worker/workspace/obj-build/dist/include/mozilla/ipc/IPDLParamTraits.h(41,26): error: no member named 'Write' in 'IPC::ParamTraits<mozilla::dom::quota::FullOriginMetadata>'
    IPC::ParamTraits<P>::Write(aMsg, std::forward<R>(aParam));
    ~~~~~~~~~~~~~~~~~~~~~^
/builds/worker/workspace/obj-build/dist/include/mozilla/ipc/IPDLParamTraits.h(64,37): note: in instantiation of function template specialization 'mozilla::ipc::IPDLParamTraits<mozilla::dom::quota::FullOriginMetadata>::Write<const mozilla::dom::quota::FullOriginMetadata &>' requested here
  IPDLParamTraits<std::decay_t<P>>::Write(aMsg, aActor,
                                    ^
/builds/worker/workspace/obj-build/dist/include/mozilla/ipc/IPDLParamTraits.h(256,7): note: in instantiation of function template specialization 'mozilla::ipc::WriteIPDLParam<const mozilla::dom::quota::FullOriginMetadata &>' requested here
      WriteIPDLParam(aMsg, aActor, aParam.ref());
      ^
/builds/worker/workspace/obj-build/dist/include/mozilla/ipc/IPDLParamTraits.h(64,37): note: in instantiation of member function 'mozilla::ipc::IPDLParamTraits<mozilla::Maybe<mozilla::dom::quota::FullOriginMetadata>>::Write' requested here
  IPDLParamTraits<std::decay_t<P>>::Write(aMsg, aActor,
                                    ^
/builds/worker/workspace/obj-build/ipc/ipdl/PQuotaRequest.cpp(348,5): note: in instantiation of function template specialization 'mozilla::ipc::WriteIPDLParam<const mozilla::Maybe<mozilla::dom::quota::FullOriginMetadata> &>' requested here
    WriteIPDLParam(aMsg, aActor, (aVar).maybeFullOriginMetadata());
    ^
In file included from UnifiedProtocols24.cpp:2:
In file included from /builds/worker/workspace/obj-build/ipc/ipdl/PQuotaRequest.cpp:18:
In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/ipc/ShmemMessageUtils.h:11:
/builds/worker/workspace/obj-build/dist/include/mozilla/ipc/IPDLParamTraits.h(47,33): error: no member named 'Read' in 'IPC::ParamTraits<mozilla::dom::quota::FullOriginMetadata>'
    return IPC::ParamTraits<P>::Read(aMsg, aIter, aResult);
           ~~~~~~~~~~~~~~~~~~~~~^
/builds/worker/workspace/obj-build/dist/include/mozilla/ipc/IPDLParamTraits.h(72,30): note: in instantiation of function template specialization 'mozilla::ipc::IPDLParamTraits<mozilla::dom::quota::FullOriginMetadata>::Read<mozilla::dom::quota::FullOriginMetadata>' requested here
  return IPDLParamTraits<P>::Read(aMsg, aIter, aActor, aResult);
                             ^
/builds/worker/workspace/obj-build/dist/include/mozilla/ipc/IPDLParamTraits.h(278,12): note: in instantiation of function template specialization 'mozilla::ipc::ReadIPDLParam<mozilla::dom::quota::FullOriginMetadata>' requested here
      if (!ReadIPDLParam(aMsg, aIter, aActor, aResult->ptr())) {
           ^
/builds/worker/workspace/obj-build/dist/include/mozilla/ipc/IPDLParamTraits.h(72,30): note: in instantiation of member function 'mozilla::ipc::IPDLParamTraits<mozilla::Maybe<mozilla::dom::quota::FullOriginMetadata>>::Read' requested here
  return IPDLParamTraits<P>::Read(aMsg, aIter, aActor, aResult);
                             ^
/builds/worker/workspace/obj-build/ipc/ipdl/PQuotaRequest.cpp(359,12): note: in instantiation of function template specialization 'mozilla::ipc::ReadIPDLParam<mozilla::Maybe<mozilla::dom::quota::FullOriginMetadata>>' requested here
    if ((!(ReadIPDLParam(aMsg, aIter, aActor, (&((aVar)->maybeFullOriginMetadata())))))) {
           ^
2 errors generated.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I guess this could be unified build bustage?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Yeah, looking at UnifiedProtocols23.cpp and UnifiedProtocols24.cpp on a local build with this backed out, PQuotaRequest.cpp lived in 23 previously where I assume it got what it needed by way of PQuota.cpp or something?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Bug 1700463 was a previous instance of bustage along these lines involving UnifiedBindings. This could probably be reproduced without --disable-accessibility by playing around with the value of https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/frontend/data.py#377.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

I think dom/quota/PQuotaRequest.ipdl needs include "mozilla/dom/quota/SerializationHelpers.h"; added to it.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1739677 - Fix includes for PQuotaRequest.ipdl.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cd924fe39cb
Fix includes for PQuotaRequest.ipdl. r=jrmuizel

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/2cd924fe39cb