1739997 - No telemetry event is registered when clicking “Discover more” button from the CTA Only module

Status: VERIFIED FIXED

(Firefox :: Pocket, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: DiscoverMore_CTAOnly_NoTelemetry.gif

[Affected versions]:

• Firefox Beta 95.0b4 (Build ID: 20211107190147)

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6
• Ubuntu 20.04

[Prerequisites]:

• Have the Firefox browser installed and opened.
• Have the “reader.pocket.ctaVersion” pref set to ”cta-only” value.
• Be logged in to Pocket.

[Steps to reproduce]:

1. Navigate to any page that supports Reader View mode.
2. Click the "Reader View" button from the right part of the Address Bar.
3. Scroll down the page until the CTA module is visible.
4. Click the “Discover more” button.
5. Navigate to the "about:telemetry#events-tab" page and observe the last event sent.

[Expected result]:

• A specific telemetry event for clicking the button is displayed.

[Actual result]:

• No telemetry event is displayed for clicking the “Discover more” button.

[Notes]:

• This issue is not reproducible for the “Discover more” button from the CTA Plus Recs module.
• Attached is a screen recording of the issue.

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1739997 - Fixing missing telemetry

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b2f115afca9
Fixing missing telemetry r=thecount

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52f613c055a3
lint fix r=fix

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4b2f115afca9
https://hg.mozilla.org/mozilla-central/rev/52f613c055a3

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 96.0a1 (Build ID: 20211111045525) on Windows 10 x64, macOS 11.6 and Ubuntu 20.04.

• The telemetry event for clicking the “Discover more” button from the CTA Only module is registered.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gsuntop, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Gavin Suntop [:gvn] (they/them)]

[Tracking Requested - why for this release]: Telemetry is needed for pending experiment.

Comment 8

[Gavin Suntop [:gvn] (they/them)]

Comment on attachment 9250265 [details]
Bug 1739997 - Fixing missing telemetry

Beta/Release Uplift Approval Request

• User impact if declined: We will lose needed telemetry to measure user sentiment.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are using an established telemetry methodology.
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc]

Gavin, you requested uplift for the patch landed in https://hg.mozilla.org/mozilla-central/rev/4b2f115afca9 but not for the lint fix in https://hg.mozilla.org/mozilla-central/rev/52f613c055a3. I am assuming you also want to uplift this one? Thanks

Comment 10

[Gavin Suntop [:gvn] (they/them)]

@Pascal Yes please!

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9250265 [details]
Bug 1739997 - Fixing missing telemetry

Approved for 95 beta 8, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/63498691dca9
https://hg.mozilla.org/releases/mozilla-beta/rev/931a3e3715aa

Comment 13

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using Firefox Beta 95.0b8 (Build ID: 20211116185800) on Windows 10 x64, macOS 11.6 and Ubuntu 20.04.

• The telemetry event for clicking the “Discover more” button from the CTA Only module is registered.