1740226 - Enable monitoring login attempts to mark a site high-value

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P3)

Description

[Dimi Lee [:dimi]]

In Bug 1729640, we introduced fission.highValue.login.monitor pref to add high-value permission when a login attempt is detected. Note that turning on the pref doesn't necessarily mean we start to isolate high-value sites. Instead, the pref should be turned on prior to enabling isolating high-value sites feature so when the feature is on, we will have the permission stored in the permission manager.

Comment 1

[Dimi Lee [:dimi]]

Hi Chris, I guess this is something you should be aware of and decide the timeline to enable it.

Comment 2

[Chris Peterson [:cpeterson]]

the pref should be turned on prior to enabling isolating high-value sites feature so when the feature is on, we will have the permission stored in the permission manager.

Is this a new Android app permission (that will cause the Android app updater to ask the user to accept this permission) or just new metadata in Firefox's own site permissions manager?

Comment 3

[Chris Peterson [:cpeterson]]

farre told me this feature is doesn't require a new Android app permission. It adds a new permission to identify high-value sites in the Firefox permission manager. Since the new permission is set by a callback at site login time, the sooner we enable this login monitoring, the more high-value sites will be flagged in the permission manager. So we should enable this for Android (only) soon.

Comment 4

[Andreas Farre [:farre]]

Try doesn't seem to object: https://treeherder.mozilla.org/jobs?repo=try&revision=249bbb2531f32c008fd99895a7f06d85f9de3dac

Comment 5

[Andreas Farre [:farre]]

Attachment: Bug 1740226 - Enable monitoring login attempts to mark a site high-value. r=agi!

Comment 6

[Chris Peterson [:cpeterson]]

Setting status-firefox99=wontfix because it's too late to land in Nightly 99. The Nightly 99 code freeze starts tomorrow and merges to Beta next week.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:farre, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/420c2ea69d18
Enable monitoring login attempts to mark a site high-value. r=agi

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/420c2ea69d18