1740244 - [Enhancement] Consider disabling right and middle-click events inside the PIP window

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[Robert Martin [:romartin], Ecosystem QA]

[Notes]:

• Usually right-click is associated with opening a menu and middle-click with opening a new tab.

[Affected Versions]:

• Firefox Release 94.0.1 (Build ID: 20211103134640)
• Firefox Beta 95.0b4 (Build ID: 20211107190147)
• Firefox Nightly 96.0a1 (Build ID: 20211109093712)

[Affected Platforms]:

• Windows 10 (x64)
• macOS 11.6
• Ubuntu Linux 20.04 x64

[Prerequisites]:

• Have the latest version of Firefox Release installed.

[Steps to reproduce]:

1. Navigate to “https://youtube.com”.
2. Open any video.
3. Hover the content of the video and click the “Watch in Picture-in-Picture” button.
4. Right-click the Play/Pause button inside the newly opened Picture-in-Picture window.

[Expected results]:

• The video is still playing.

[Actual results]:

• The video is paused.

Comment 1

[kpatenio]

Attachment: ubuntu_20_04_3_right_click_pip_window.png

Apparently a context menu appears when right clicking on the PiP window when using Ubuntu 20.04.3. (See attached photo).

I do not see any context menus for Windows 10 and MacOS Big Sur after right clicking on the PiP window. We may not want to disable right click events completely for Linux users.

Comment 2

[Rashelle]

Attachment: Bug 1740244 - Don't run PiP button events when middle and right click is used r?kpatenio,mhowell

Comment 3

[Micah [:mtigley] (she/her)]

(In reply to kpatenio from comment #1)

Created attachment 9252688 [details]
ubuntu_20_04_3_right_click_pip_window.png

Apparently a context menu appears when right clicking on the PiP window when using Ubuntu 20.04.3. (See attached photo).

I do not see any context menus for Windows 10 and MacOS Big Sur after right clicking on the PiP window. We may not want to disable right click events completely for Linux users.

Interesting. Is that an OS context menu? I don't think that's PiP window specific.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

That's coming from the window manager, it looks like. I don't think disabling our event handling should affect it?

Comment 5

[Rashelle]

Attachment: Bug 1740244 - Don't run PiP button events when middle and right click is used r?kpatenio,mhowell

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44fd8a4d2336
Don't run PiP button events when middle and right click is used r=kpatenio,mhowell

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/44fd8a4d2336

Comment 8

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the middle click and the right click button events are not running in PiP using Firefox Nightly 97.0a1 (Build ID: 20211220094500) on Windows 10 x64, macOS 11.6, and Ubuntu Linux 20.04 x64.