1740359 - MinGW header lacks of some attributes of MFT_MESSAGE_TYPE

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Alastor Wu [:alwu]]

The current definition of MFT_MESSAGE_TYPE doesn't match the definition of MS's one, it lacks some attributes which causes bug 1740131.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Looks like these are generated from idl and we/mingw folks need to update those definitions.

Going of the magic number DB I think the new def would be

typedef enum _MFT_MESSAGE_TYPE {
    MFT_MESSAGE_COMMAND_FLUSH                   = 0x00000000,
    MFT_MESSAGE_COMMAND_DRAIN                   = 0x00000001,
    MFT_MESSAGE_SET_D3D_MANAGER                 = 0x00000002,
    MFT_MESSAGE_DROP_SAMPLES                    = 0x00000003,
    MFT_MESSAGE_COMMAND_TICK                    = 0x00000004,
    MFT_MESSAGE_NOTIFY_BEGIN_STREAMING          = 0x10000000,
    MFT_MESSAGE_NOTIFY_END_STREAMING            = 0x10000001,
    MFT_MESSAGE_NOTIFY_END_OF_STREAM            = 0x10000002,
    MFT_MESSAGE_NOTIFY_START_OF_STREAM          = 0x10000003,
    MFT_MESSAGE_NOTIFY_RELEASE_RESOURCES        = 0x10000004,
    MFT_MESSAGE_NOTIFY_REACQUIRE_RESOURCES      = 0x10000005,
    MFT_MESSAGE_NOTIFY_EVENT                    = 0x10000006,
    MFT_MESSAGE_COMMAND_SET_OUTPUT_STREAM_STATE = 0x10000007,
    MFT_MESSAGE_COMMAND_FLUSH_OUTPUT_STREAM     = 0x10000008,
    MFT_MESSAGE_COMMAND_MARKER                  = 0x20000000
} MFT_MESSAGE_TYPE;

I image that would be sufficient to fix the issue in bug 1740131, but don't know much about mingw and if they'd need further changes elsewhere (like tests).

Comment 2

[[:sergesanspaille]]

I've checked upstream and the definitions are still inconsistent with MS' one: https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/mftransform.h#l108

The original build issue being fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1740131 , I think it's fine to close this one.

Maybe Tom has an extra opinion?

Comment 3

[Tom Ritter [:tjr] (OOTO until mid-August)]

No; we like to keep these issue open (and blocking mingw-clang meta bug) so that when we update the mingw headers (which I am working on now) we can go through and remove the mingw hack-arounds and validate the fixes.

Comment 4

[Tom Ritter [:tjr] (OOTO until mid-August)]

Attachment: Bug 1740359: Define the MFT_MESSAGE_TYPE's for MinGW r?#build

Depends on D169372

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a603660fe583
Define the MFT_MESSAGE_TYPE's for MinGW r=media-playback-reviewers,alwu

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a603660fe583