1740492 - Cannot remove text range in a span with contenteditable="true" when text contains <br> tags

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Guille]

Attachment: span_bug.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

Select a text range (using keyboard or mouse) that includes at least one of the <br> tags inside the span tag and press the delete key or Remove in the context remove of the selection.

Actual results:

Nothing happened.

Expected results:

The selected text should have been removed. This works on Firefox 92 and other browsers.

Comment 1

[Alice0775 White]

I can reproduce the issue in Nightly96.0a1 Windows10.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3db432e2820882f8a29b52e4a3a0baee9e8d19eb&tochange=7af78405aade4dbd64f4c713dc3feeed5d8ffa5b

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I know only a few web apps uses inline editing host, but this symptom is serious for such web apps.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Looks like that this is a dup of bug 1737540. I cannot reproduce this bug with the latest Nightly. Could you re-test this with the latest Nightly build?

Comment 4

[Alice0775 White]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #3)

Looks like that this is a dup of bug 1737540. I cannot reproduce this bug with the latest Nightly. Could you re-test this with the latest Nightly build?

Confirmed. It was fixed in Nightly96.0a1(20211110214946) Windows10.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Does the testcase from bug 1737540 cover this too or should we land a different one to cover this?

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Does the testcase from bug 1737540 cover this too or should we land a different one to cover this?

Not covered. I'll add WPT.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1740492 - Add tests for the symptom (the bug has already been fixed by bug 1737540) r=m_kato!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fccb09f46f3e
Add tests for the symptom (the bug has already been fixed by bug 1737540) r=m_kato

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31630 for changes under testing/web-platform/tests

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fccb09f46f3e

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot