1740543 - Expose GetErrorName to JS so that JS code can decipher error codes

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Doing this would allow to get rid of this weak copy of all the error codes:
https://searchfox.org/mozilla-central/rev/267682a8f45221bf0bfe999d4a0239706a43bc56/devtools/server/actors/network-monitor/utils/network-utils.js#33

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1740543 - Expose xpcom's GetErrorName() to JS.

This will help JS codebase decipher what a given nsresult refers to.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4628f9ff25a5
Expose xpcom's GetErrorName() to JS. r=xpcom-reviewers,nika

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages on ErrorNames

Backout link: https://hg.mozilla.org/integration/autoland/rev/5fdacd892bcdf5426213766277bfdc3c17efb2b7
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4628f9ff25a5ad380f29ed8942706e2cc586caea&selectedTaskRun=ed0JjfrFRX-qcL6U3MR1mg.0
Failure log: https://treeherder.mozilla.org/logviewer?job_id=360619243&repo=autoland&lineNumber=85828
Failure line: /builds/worker/checkouts/gecko/xpcom/base/ErrorNames.cpp:50:26: error: use of undeclared identifier 'NS_IsMainThread' // gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:660: ErrorNames.o] Error 1

Comment 4

[Alexandre Poirot [:ochameau]]

Looks like I missed some include, it should be fixed now:
https://treeherder.mozilla.org/jobs?repo=try&revision=6f81618034fd6b2cf7c46f92ecae23f193dc05d3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a2d38dcce42
Expose xpcom's GetErrorName() to JS. r=xpcom-reviewers,nika

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3a2d38dcce42