1740569 - BlockedDllList annotation is missing if the launcher process is enabled

Status: RESOLVED FIXED

(Firefox :: Launcher Process, defect)

Description

[Toshihito Kikuchi [:toshi]]

I happened to realize BlockedDllList annotation is not set if the launcher process is enabled. Bug 1420363 changed the type of the first parameter of DllBlocklist_WriteNotes from HANDLE to AnnotationWriter&, but firefox!NativeNtBlockSet_Write still receives the first parameter as HANDLE. As a result, WriteFile never succeeds.

Comment 1

[Toshihito Kikuchi [:toshi]]

With the patch, we can see the BlockedDllList annotation when LauncherProcessState is 0 (= Enabled).

• x86 https://crash-stats.mozilla.org/report/index/a56b7106-bcb3-4d20-984c-55e8b0211110
• x64 https://crash-stats.mozilla.org/report/index/1aef592f-4dba-4d58-9597-4e5220211110

Comment 2

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1740569 - NativeNtBlockSet_Write needs to receive AnnotationWriter. r=gsvelto

Bug 1420363 changed the type of WriterFn's parameter from HANDLE to
AnnotationWriter& and rewrote InternalWriteNotes in mozglue.dll, but
it didn't update NativeNtBlockSet_Write in firefox.exe, which is used
when the launcher process is enabled.

This patch applies a part of D46848 to NativeNtBlockSet_Write.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1420363

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/908a35db1348
NativeNtBlockSet_Write needs to receive AnnotationWriter.  r=gsvelto

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/908a35db1348

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this worth backporting to ESR91 also? It grafts cleanly.

Comment 7

[Toshihito Kikuchi [:toshi]]

We don't need to. Without this patch, we miss the annotation field BlockedDllList, but we haven't been actively monitoring it. There is no behavior change visible to users nor benefit for users.