1740601 - Initial implementation of `scripting.executeScript()`

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[William Durand [:willdurand]]

Let's start by shipping the json schema and a working MVP of the scripting.executeScript() API.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1740601 - Initial implementation of `scripting.executeScript()`. r?robwu!

The implementation does not support the following features yet:

• target.allFrames: because I expect some changes in the tabs API to
  be able to "link" a frameId to a result. That can be done in a
  further iteration
• execution world (main vs isolated): because that can also be added
  later
• files can accept more than one file but we only execute the first
  one for now...

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69dee748c290
Initial implementation of `scripting.executeScript()`. r=robwu

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest plain leaks

Backout link: https://hg.mozilla.org/integration/autoland/rev/38fdb8f041f1dea3228f5f87eb4437a99cf38134
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=JBmPUnuTQs-nHQhkRIgRuQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=69dee748c290020ad8ad0b4c40615d29494dbbad
Failure log: https://treeherder.mozilla.org/logviewer?job_id=358215833&repo=autoland&lineNumber=6787

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5476bbc1844c
Initial implementation of `scripting.executeScript()`. r=robwu

Comment 5

[William Durand [:willdurand]]

The test failures were not related to this patch, although the added test file revealed the bug. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1741600 for that actual bug and skipped the test in debug mode for now.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5476bbc1844c