1740696 - [DE][otto.de] Credit Card type is not selected by autofill

Status: REOPENED

(Toolkit :: Form Autofill, defect, P3)

Description

[Alin Ilea, Desktop QA]

Attachment: 2021-11-11_12h26_30.mp4

Affected Versions:

All latest Firefox versions: Nightly 96.0a1, Beta 95, Release 94

Tested on:

MacOS 10.15
Windows 10

Preconditions:

browser.search.region DE
extensions.formautofill.supportedCountries DE
download latest Firefox Nightly with region locale (switch extensions.formautofill.available to "on" for testing non-Nightly builds)

Steps to reproduce:

1. Reach the payment form on otto.de
2. Using autofill feature, select 1 saved CC entry.
3. Click on any auto-filled field and choose to "Clear Form".

Expected Results:

1. Credit card type should be selected.
2. Credit card type should have the specific autofill yellow highlight.
3. Credit card type dropdown should be reset and cleared upon "Clear Form".

Actual Results:

1. Cred card type is not selected.
2. Credit card type does not have the specific autofill yellow highlight.
3. Credit card type dropdown is not reset and cleared upon "Clear Form".

Notes:

Severity: S3
Regression range: not a recent regression.
For the expiry date dropdowns that also have no yellow highlight and not reset and cleared upon "Clear Form": bug 1740693.

Comment 1

[Sergey Galich [:serg]]

6011434541351602 belongs to Maestro which is owned by Mastercard. We need to check if this site offers Maestro support.

Comment 2

[Alin Ilea, Desktop QA]

@Sergey there is the same behavior using Visa or American Express CC type, which the site specify that are supported.

Comment 3

[Tim Giles [:tgiles]]

Attachment: Bug 1740696 - Add 'kartenmarke' to cc-type heuristic for DE locales. r=dimi

Comment 4

[Tim Giles [:tgiles]]

Note for QA: the current patch attached to this bug will not fix the missing yellow highlight on card type nor will if fix the dropdown select elements not resetting on "clear form". These two issues will be addressed in bug 1740693 so I think we'll need a follow up bug with those two issues for otto.de after the current patch lands. Disregard this comment, we have Bug 1740693 as follow up. I'm going to edit the title of this bug so that it is more accurate

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ca9c7191c81
Add 'kartenmarke' to cc-type heuristic for DE locales. r=dimi

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5ca9c7191c81

Comment 7

[Timea Cernea [:tbabos][inactive]]

Hey Tim, I am still able to reproduce this issue on the latest Firefox Nightly 96.0a1 (2021-11-18) (BuildID: 20211118212756), tested on MacOS 10.15. Here is an uploaded screen-recording: https://drive.google.com/file/d/1XqTS5eE5qAmGGmbp44dyzEqfQe-0ZvKr/view?usp=sharing

Comment 8

[Tim Giles [:tgiles]]

Thanks for the update Timea, reopening and should have an updated patch today

Comment 9

[Tim Giles [:tgiles]]

Attachment: Bug 1740696 - Add 'kkname' to cc-type heuristic to fix identifying card type on otto.de. r=dimi

Comment 10

[Alin Ilea, Desktop QA]

Still reproducible in latest Nighly 100.0a1 and Beta 99.0b1.

Comment 11

[Tim Giles [:tgiles]]

I've verified that this issue will be fixed once we enable Fathom for credit card autofill. I was able to verify this by setting extensions.formautofill.creditCards.heuristics.mode to 2 and then going through the checkout process on Otto. The card type was picked out correctly when Fathom is enabled for autofill. Because of this, this bug is now blocked by Bug 1759418.

Alin, when you have time and/or do another test run of credit card autofill, no rush either way, could you see if setting extensions.formautofill.creditCards.heuristics.mode to 2 will fix some of the previously filed bugs that dependents of Bug 1687633? If some of these bugs can be fixed by Fathom, then they should be updated to being blocked by Bug 1759418. A note for testing with extensions.formautofill.creditCards.heuristics.mode, this value can be changed without restarting the browser but if it is changed, then the current page will need to be refreshed so that Fathom can identify the fields instead of our old heuristics.

Comment 12

[Alin Ilea, Desktop QA]

Sure thing, we'll verify and update the bugs as soon as we can (it will take some time since there are a lot of bugs). Leaving the NI for me as a reminder.
Thanks!