174072 - When I went to about:plugins the file names come up unreadable.

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P4)

Description

[bryan]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.2b) Gecko/20021011
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.2b) Gecko/20021011

Hi,
When I went to check what plugins I have configered for my browser I could not
read the c:\ file names they have lines thruogh them. Phoenix 0.2 alos has that
problem. I can not figer out why that is happening.

Reproducible: Always

Steps to Reproduce:
1.Type about:plugins in the url bar.
2.
3.

Actual Results:  
The same. 

Expected Results:  
To let me see the file names.

Comment 1

[Boris Zbarsky [:bzbarsky]]

*** Bug 174073 has been marked as a duplicate of this bug. ***

Comment 2

[Matthias Versen [:Matti]]

Can you please attach a screenshot ?

Comment 3

[Warner Young]

I can see this on build 2002101015, using Modern theme, too.  Confirming, and
will attach screenshot.

Comment 4

[Warner Young]

Attachment: Screenshot of plugin filename running into other text.

Seems to depend on the "message font", which is MS Sans Serif on my system.

Comment 5

[shrirang khanzode]

beppe, u saw this last week , I remember.

Comment 6

[Warner Young]

In fact, I'm sure it's "message font" that causes this, because when I comment
out that line in plugins.css, it fixes the problem.

Comment 7

[rubydoo123]

yes I saw this on win98 but I am not seeing it on winXP. Assigning to Anthony to
see if he can hunt down the root of the issue

Comment 8

[anthonyd]

I can't reproduce this, and I groked my plugins.css for "message font" and
couldn't find it.  I also tried playing with the fonts in the prefs panel and
could'nt get it to happen either.

Can anyone give me some clues?

Comment 9

[Warner Young]

Only happens with certain themes.  Modern seems to have this problem, but
Classic doesn't.  I was working on a theme of my own and had this problem.  I
believe the problem only happens if the font used for "message-font" is actually
a bitmap font instead of a TrueType font.  That *should* mean you won't see it
on WinXP, and possibly not on Win2K, either, since I think all the default
system fonts are TrueType.  That would imply it's Win9x, possibly NT4, only.

Comment 10

[Warner Young]

*** Bug 175566 has been marked as a duplicate of this bug. ***

Comment 11

[anthonyd]

I cannot reproduce this on win2k with the modern or classic theme.  Does anyone
have the ability to test this on winNT?

Comment 12

[rubydoo123]

I cannot repro this on winXP, but can dup it on win2K -- sorry I do not have NT

Comment 13

[anthonyd]

*** Bug 174138 has been marked as a duplicate of this bug. ***

Comment 14

[Matthias Versen [:Matti]]

*** Bug 180225 has been marked as a duplicate of this bug. ***

Comment 15

[rubydoo123]

Could this be a result of users not having the specified font from the style
sheet? When I looked at chrome://communicator/skin/plugins.css it calls for the
lable to be italic, if I change that to normal, the text renders fine.

Robert: could you possibly revert the label to normal instead of italic?

Comment 16

[Warner Young]

Beppe, as I mention in comment #9, I'm pretty sure the problem is due to the use
of a bitmap font.  Since bitmap fonts only have certain sizes, I would guess
your idea may be what's happening.  I don't know how Mozilla internally handles
the case where the font returned by the system isn't *exactly* the same as the
one requested.

Comment 17

[rubydoo123]

Right: it may be a combination of things -- it might be simpler to refer to
either serif or sans-serif and let the system pick an appropriate font in that
family. Removing the italic helped, could be that the replacement font for the
bitmap font did not have italic (a guess anyway).

Robert: any chance of possibly using a family rather than a specific font and style?

Comment 18

[Robert Kaiser]

beppe:
Well, it's no problem to use family, I just thought it should blend in with the
theme's other choices of fonts, and re-used that.
I think it may be better to just remove italic and continue to use the same font
as those themes use for other UI elements as well. It seems we don't use italic
in UI anywhere, I never realized that :)

Comment 19

[rubydoo123]

sure, that sounds fair

Comment 20

[Robert Kaiser]

Attachment: patch: removing italic definition

This patch removes that italic definition from the mordern theme, as it seems
we don't use italic anywhere else in UI, this also helps consistency.

Comment 21

[rubydoo123]

r=beppe

looks good

Comment 22

[Robert Kaiser]

Comment on attachment 106813 [details] [diff] [review]
patch: removing italic definition

adding r=beppe, requesting sr= from bz

Comment 23

[Robert Kaiser]

hmm, the new attachment flag system lists it as if I would have given r= - would
be better if beppe would have set review+ on the attachment himself...

Comment 24

[Robert Kaiser]

Checking in plugins.css;
/cvsroot/mozilla/themes/modern/communicator/plugins.css,v  <--  plugins.css
new revision: 1.2; previous revision: 1.1
done


fixed.

Comment 25

[Matthias Versen [:Matti]]

*** Bug 183794 has been marked as a duplicate of this bug. ***