1740739 - Implement AddInputBlockCallback for remote APZCTreeManager

Status: RESOLVED FIXED

(GeckoView :: General, task, P3)

Description

[Jamie Nicol [:jnicol]]

In bug 1633322 an API AddInputBlockCallback was added to APZCTreeManager. This is used by android, and since there is no GPU process on Android it was not implemented for APZCTreeManagerChild.

I am now working on getting the GPU process running on Android, so we now need a remote implementation of this.

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Bug 1740739 - Implement AddInputBlockCallback for APZCTreeManagerChild. r?botond

In bug 1633322 the AddInputBlockCallback API was added to
APZCTreeManager. This is only used by android, and since there is no
GPU process on Android it was not implemented for
APZCTreeManagerChild. This patch adds a remote APZCTreeManager
implementation in preparation for adding a GPU process for Android.

APZCTreeManagerChild::AddInputBlockCallback() works by maintaining a
local map of the added callbacks. It sends a message to the parent via
SendAddInputBlockCallback(), and in RecvAddInputBlockCallback() the
parent calls AddInputBlockCallback() on its local APZCTreeManager
instance. This callback is simply responsible for sending a message
back to the child with SendCallInputBlockCallback(). Upon receiving
this message the child will, finally, look up the original callback
from its local map and call it.

Some care must be taken with the intermediate callback described
above, as because APZCTreeManagerParent is not a refcounted type we
cannot safely capture a reference to it. Instead, we capture the
APZCTreeManagerParent's LayersId, and then look up the instance from
the CompositorBridgeParent using the ID.

Depends on D131120

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62c1982adb93
Implement AddInputBlockCallback for APZCTreeManagerChild. r=botond

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/62c1982adb93