Two error conditions are missing text
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: mixedpuppy, Assigned: robwu)
Details
Attachments
(1 file)
Errors get used to display a message in a panel. There are currently 7 errors, but only 5 actually have text.
[1] https://searchfox.org/mozilla-central/rev/df6434d2ebfdf2b5f89f205fc81d60d64a774fe1/browser/base/content/browser-addons.js#806-814
[2] https://searchfox.org/mozilla-central/rev/88cd13997fb0747cdcd78638fc762ff2d75e1fc5/toolkit/mozapps/extensions/AddonManager.jsm#3787-3802
[3] https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties#230-241
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•4 years ago
|
||
ERROR_UNEXPECTED_ADDON_TYPE is triggered when a WebExtension is changed to a non-WebExtension. We don't support non-WebExtensions, the only entries are old installations, so this scenario is not possible any more.
ERROR_INCORRECT_ID is when the addon ID changes during an upgrade. That shouldn't happen, and it's an error of the add-on distributor.
https://searchfox.org/mozilla-central/rev/3c8a7970944daaf917b547dffc0790bcd37cadc1/toolkit/mozapps/extensions/internal/XPIInstall.jsm#1535-1550
Only the last one may be worth translating.
|
|
Assignee | |
Comment 2•3 years ago
|
||
ERROR_UNEXPECTED_ADDON_TYPE will be re-used by my patch to bug 1750565.
While testing that manually, I realized that these errors (ERROR_UNEXPECTED_ADDON_TYPE and ERROR_INCORRECT_ID) only happen as a part of updates (automatic or manual updates), and immediately interrupt the update flow without UI (e.g. doorhangers). The error is dumped to the console.
The logic referenced in this report is about doorhangers that appear when a non-update XPI installation is triggered.
When someone attempts to (re-)install a XPI, then that doesn't count as an update, and the install flow does not account for the existing add-on (i.e it's not an update, and the branches that yields the two error codes are not taken).
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
||
Updated•3 years ago
|
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Description
•