1740840 - "Always Open Similar Files" availability is intermittent

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

[Description:]

This issue varies depending on the used extension for the test and probably on operating system defaults as well.

[Environment:]

Windows 10
96.0a1 20211111211702

[Steps:]

1. Open Firefox
2. Access https://ftp.mozilla.org/pub/firefox/releases/0.10.1/
3. Click on the exe file to trigger the download.
4. After the file is downloaded right click on it in both the Download Panel and in the Download history and check the availability of the "Always Open Similar Files". (bug 1738111)
5. Restart Firefox and recheck again availability for "Always Open Similar Files"
6. Access https://ftp.mozilla.org/pub/firefox/releases/1.0.2/win32/el-GR/ and download another exe.

[Actual Result:]

Screencast1 - with overwrite copy/dedupe
Screencast2 - with two exe files having different options
"My guess is that ""Always Open Similar Files"" works after browser restart because somehow it managed to get hold of the default system handler but for the new .exe. on the refetch(?) it hits again the same wall. "

[Expected Result:]

Download Panel and Download History should behave and function on the same rules

Comment 1

[:Gijs (he/him)]

This is because download.contentType doesn't exist for downloads from previous sessions, and as Micah notes in bug 1738918 comment 1, we rely on it to make decisions:

https://searchfox.org/mozilla-central/rev/a12c2c2e59c92d8f969d8f3f290ab16919449c9d/browser/components/downloads/DownloadsViewUI.jsm#246-251

We should either infer the content type from the file extension, or we should not offer the option for downloads without a content type at all.

Comment 2

[Romain Testard [:RT]]

Is this a regression related to the download modal removal or did this behavior already exist previously?

Comment 3

[:Gijs (he/him)]

(In reply to Romain Testard [:RT] from comment #2)

Is this a regression related to the download modal removal or did this behavior already exist previously?

It did not exist before; the context menu we added to the download panel to allow users to configure filetypes ("always open similar files") is not working correctly.

Comment 4

[kpatenio]

Attachment: Bug 1740840 - use mimeinfo content type to fix downloads intermittent alwaysOpenSimilarFiles. r=gijs!,mtigley!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d688eec19e23
use mimeinfo content type to fix downloads intermittent alwaysOpenSimilarFiles. r=Gijs,mtigley

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/d688eec19e23