Closed
Bug 1740858
Opened 3 years ago
Closed 3 years ago
Clean up `SplitNodeResult` for making the split direction switchable
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
96 Branch
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•3 years ago
|
||
First, left/right node accessors are not used so that we can get rid of them.
However, we should have similar methods which can retrieve original node and
new node. Therefore, this adds GetNewContent()
and GetOriginalContent()
.
Next, SplitPoint()
should return both EditorDOMPoint
and EditorRawDOMPoint
for avoiding unnecessary conversion from EditorRawDOMPoint
to
EditorDOMPoint
. Therefore, this patch makes it a template method too.
Finally, this patch adds helper methods to get point of each related content.
E.g., AtNewContent()
corresponding to GetNewContent()
.
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/aeb15abd2346
Improve `SplitNodeResult` r=m_kato
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•