1741149 - updateBrowserRemoteness throws intermittently

Status: ASSIGNED

(Firefox :: Tabbed Browser, defect)

Description

[Jens Stutte [:jstutte]]

There is a series of intermittents that carry a similar sequence of events:

[task 2021-11-10T11:51:23.357Z] 11:51:23     INFO - PID 8821 | [Parent 8821, IPC I/O Parent] WARNING: Failed to launch tab subprocess: file /builds/worker/checkouts/gecko/ipc/glue/GeckoChildProcessHost.cpp:750
[task 2021-11-10T11:51:23.364Z] 11:51:23     INFO - PID 8821 | JavaScript error: chrome://browser/content/tabbrowser.js, line 1909: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIWebProgress.removeProgressListener]
[task 2021-11-10T11:51:23.367Z] 11:51:23     INFO - PID 8821 | JavaScript error: chrome://browser/content/tabbrowser.js, line 1909: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIWebProgress.removeProgressListener]
[task 2021-11-10T11:51:23.594Z] 11:51:23     INFO - PID 8821 | 1636545083586	Marionette	ERROR	TypeError: can't access property "addMessageListener", this.mm is null(chrome://remote/content/marionette/dom.js:50:5) JS Stack trace: [e-mail]:50:5
[task 2021-11-10T11:51:23.594Z] 11:51:23     INFO - PID 8821 | [e-mail]:398:26
[task 2021-11-10T11:51:23.596Z] 11:51:23     INFO - PID 8821 | [e-mail]:1232:35
[task 2021-11-10T11:51:23.596Z] 11:51:23     INFO - PID 8821 | [e-mail]:1172:18
[task 2021-11-10T11:51:23.596Z] 11:51:23     INFO - PID 8821 | [e-mail]:306:40
[task 2021-11-10T11:51:23.596Z] 11:51:23     INFO - PID 8821 | [e-mail]:279:16
[task 2021-11-10T11:51:23.596Z] 11:51:23     INFO - PID 8821 | onPacket/<@server.js:252:20
[task 2021-11-10T11:51:23.596Z] 11:51:23     INFO - PID 8821 | [e-mail]:253:9
[task 2021-11-10T11:51:23.596Z] 11:51:23     INFO - PID 8821 | _onJSONObjectReady/<@transport.js:500:20
[task 2021-11-10T11:51:23.596Z] 11:51:23     INFO - NoSuchWindowException on command, setting status to CRASH
[task 2021-11-10T11:51:23.597Z] 11:51:23     INFO - TEST-UNEXPECTED-CRASH | /service-workers/service-worker/state.https.html | expected OK
[task 2021-11-10T11:51:23.598Z] 11:51:23     INFO - TEST-INFO took 617ms
[task 2021-11-10T11:51:23.604Z] 11:51:23     INFO - PID 8821 | 1636545083604	Marionette	INFO	Stopped listening on port 47567
[task 2021-11-10T11:51:23.784Z] 11:51:23     INFO - PID 8821 | WARNING: A blocker encountered an error while we were waiting.
[task 2021-11-10T11:51:23.787Z] 11:51:23     INFO - PID 8821 |           Blocker:  SessionStore: flushing all windows
[task 2021-11-10T11:51:23.788Z] 11:51:23     INFO - PID 8821 |           Phase: quit-application-granted
[task 2021-11-10T11:51:23.788Z] 11:51:23     INFO - PID 8821 |           State: {"total":-1,"current":-1}
[task 2021-11-10T11:51:23.788Z] 11:51:23     INFO - PID 8821 | WARNING: TypeError: can't access property "sendAsyncMessage", mm is null

The tabbed browser related message points to aBrowser.webProgress.removeProgressListener(filter); with filter being null, apparently.

It might well be just a symptom of other things going wrong earlier, but it looks like updateBrowserRemoteness could benefit from some hardening regarding missing filters/listeners in any case.

Comment 1

[Jens Stutte [:jstutte]]

This is just a symptom of the failed process launch before. We still might want to improve robustness here, too, but it is not blocking anything.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Julian Descottes [:jdescottes]]

After enabling Fission for devtools tests, we started having several intermittent failures for this error, which also seem to impact other components than devtools: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=nsIWebProgress.removeProgressListener&list_id=16001529

In our tests, it seems that the failure usually happens when starting a test and opening a tab using BrowserTestUtils.addTab, although I'm unable to reproduce locally.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1741149 - Fix removeProgressListener failures in updateBrowserRemoteness. r=Gijs.

This is guarding on the existence of the listeners we're trying to remove.

Comment 18

[Intermittent Failures Robot]

42 failures in 2837 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #24 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 31
• try: 1
• mozilla-central: 7
• mozilla-beta: 2
• mozilla-release: 1

Platform and build breakdown:

• linux1804-64-asan-qr: 41
  • opt: 41
• linux1804-64-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1741149&startday=2022-03-07&endday=2022-03-13&tree=all

Comment 20

[Intermittent Failures Robot]

34 failures in 3304 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #38 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 25
• mozilla-beta: 5
• try: 2
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-asan-qr: 34
  • opt: 34

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1741149&startday=2022-03-14&endday=2022-03-20&tree=all

Comment 21

[Intermittent Failures Robot]

9 failures in 3341 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• mozilla-release: 1
• mozilla-beta: 7

Platform and build breakdown:

• linux1804-64-asan-qr: 9
  • opt: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1741149&startday=2022-03-21&endday=2022-03-27&tree=all

Comment 22

[Intermittent Failures Robot]

1 failures in 3075 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-esr91: 1

Platform and build breakdown:

• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1741149&startday=2022-06-20&endday=2022-06-26&tree=all

Comment 23

[Intermittent Failures Robot]

1 failures in 3537 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-esr91: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1741149&startday=2022-08-29&endday=2022-09-04&tree=all

Comment 24

[Intermittent Failures Robot]

1 failures in 3309 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• windows11-64-2009-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1741149&startday=2023-07-10&endday=2023-07-16&tree=all