1741217 - ManagedBookmarks policy doesn't respect "DisablePrivateBrowsing": true policy

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P2)

Description

[billy78]

Attachment: policies.json

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

1. Use ManagedBookmarks policy together with "DisablePrivateBrowsing": true policy (see attached policies.json as an example)
2. Right click on the GitHub managed bookmark

Actual results:

The context menu contains the option "open in a new private window"

Expected results:

The context menu should not contain the option "open in a new private window", just like in normal bookmarks.

Comment 1

[Jeronimo Torti (Please send NI request to Brindusa Tot)]

Hi,
I was able to reproduce this issue in Windows 10, using Nightly 96.0a1 (2021-11-16) (64-bit) and Release 94.0.1 (64-bit) versions, with provided steps.
I set severity and flags accordingly.

I let the assigned component, in order to get the dev team involved, but if it's not relevant,
'Firefox-Enterprise policies' team, please feel free to change the component if this is not the appropriate one.

Thanks.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1741217 - Hide private browsing option in managed bookmarks if private browsing is disabled. r?mstriemer,mtigley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaec88623ff0
Hide private browsing option in managed bookmarks if private browsing is disabled. r=mtigley

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/eaec88623ff0

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mkaply, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 9251017 [details]
Bug 1741217 - Hide private browsing option in managed bookmarks if private browsing is disabled. r?mstriemer,mtigley

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Enterprise/policy specific
• User impact if declined: Private browsing available in ManagedBookmarks even if disabled
• Fix Landed on Version: 94
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, has tests.
• String or UUID changes made by this patch:

Beta/Release Uplift Approval Request

• User impact if declined: Private browsing available in ManagedBookmarks even if disabled
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Install attached policies.json in bug. Verify private browsing is not available.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, has test.
• String changes made/needed:

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9251017 [details]
Bug 1741217 - Hide private browsing option in managed bookmarks if private browsing is disabled. r?mstriemer,mtigley

Approved for 95 Beta 11. Low Risk. Thanks.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/03abc08bb752

Comment 9

[Simona Badau, Desktop QA]

Verified as fixed on macOS Big Sur 11.6, Ubuntu 20.04 x64, and Windows 10 x64 using the latest Nightly 96.0a1 - "Open in New Private Window" is no longer a contextual menu option - when there is a ManagedBookmarks policy together with "DisablePrivateBrowsing": true policy.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9251017 [details]
Bug 1741217 - Hide private browsing option in managed bookmarks if private browsing is disabled. r?mstriemer,mtigley

Approved for 91.4esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/d4de29d5eff9

Comment 12

[Simona Badau, Desktop QA]

Verified as fixed on macOS Big Sur 11.6, Windows 10 x64 and Ubuntun 20.04 on the latest Firefox 95 beta 11 and on Firefox 91.4.0 esr.