1741221 - ManagedBookmarks policy can't make use of favicons if SanitizeOnShutdown policy deletes history

Status: NEW

(Firefox :: Enterprise Policies, defect, P3)

Description

[billy78]

Attachment: policies.json

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

1. Use ManagedBookmarks policy together with "SanitizeOnShutdown": { "History": true } policy (see attached policies.json as an example)
2. Click on GitHub managed bookmark to visit website.

Actual results:

Icon of GitHub bookmark is not updated to the favicon. Even restarting Firefox, icon is still not updated.

Expected results:

Icon of GitHub bookmark should have updated to the favicon and should have kept it even after restarting Firefox.
Normal bookmarks keeps their favicons, even when "SanitizeOnShutdown": { "History": true } is used.
Perhaps, there should be a Favicon property in ManagedBookmarks policy, just like the previous Bookmarks policy? Or a separate file to store the favicons for managed bookmarks?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Marcela (Please NI request to Brindusa Tot)]

Hi billy78!
I couldn't reproduce this issue on Nightly 96.0a1/20211116093425 on Windows 10. I used the file Polices.json attached to this issue following these steps:

1. Save the Policies.json file into a directory called distribution within the Firefox installation directory. (I followed this guideline: https://support.mozilla.org/en-US/kb/customizing-firefox-using-policiesjson)
2. Launch Firefox, open https://github.com/, and save as a bookmark.
   Actual result: Favicon is shown without problems. I will add the evidence in an attachment.
   Perhaps I omitted or misunderstood some steps?
   Please could you try to see if the same thing happens to you in the latest Nightly version and tell us your result? You can download it from here: https://nightly.mozilla.org/
   if still happens, could you add a screen recording that shows the problem? It would be useful to us to try to reproduce it.
   Thanks!

Comment 3

[Marcela (Please NI request to Brindusa Tot)]

Attachment: fabicon.jpg

Comment 4

[Mike Kaply [:mkaply]]

The issue is the bookmark in ManagedBookmarks, not the bookmark in the toolbar.

Comment 5

[Marcela (Please NI request to Brindusa Tot)]

Attachment: bookmark.jpg

Comment 6

[Marcela (Please NI request to Brindusa Tot)]

Hi Mike! let me know if this attachment can be useful. Apparently, the favicon is displaying well.

Comment 7

[billy78]

Marcela, as Mike pointed out, the problem exists in managed bookmarks, not regular bookmarks. Please make the bookmarks toolbar appear and there should be a "Managed Bookmarks" folder with a GitHub bookmark in it. Also, remove your own GitHub bookmark you created and restart Firefox. Then, click the managed bookmark and see that there is no favicon in it. However, if you create your own bookmark, then the managed bookmark gets the favicon, but as soon as you remove your own bookmark and restart Firefox, the managed bookmark loses the favicon.

Comment 8

[billy78]

Attachment: managedbookmarks_favicon_bug.jpg

Comment 9

[Marcela (Please NI request to Brindusa Tot)]

Thank you billy78 for your information.
I was able to reproduce it on Windows 10 on latest Nightly version 96.0a1 (2021-11-17)(64-bit), Beta 95.0b8, and Release 94.0.1. I'll set severity and change flags accordingly.