1741671 - Enable BFCache for pages with beforeunload event listeners on Desktop on Nightly

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1741671 - Enable BFCache for pages with beforeunload event listeners on Desktop r=smaug

The changes only made it works in SHIP(session-history-in-parent) only.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa8767c463fc
Enable BFCache for pages with beforeunload event listeners on Desktop r=smaug

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_navigateEvents.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/97ddae94c724f1ec9c101f6bb83b0bf04ecd8d8b
Log link: https://treeherder.mozilla.org/logviewer?job_id=368420488&repo=autoland&lineNumber=3420

Comment 4

[Sean Feng [:sefeng]]

Attachment: Bug 1741671 - Remove browser_navigateEvents.js test r=ochameau

This test does a bunch of assertions for a series of events which
is complex and not reliable. It also becomes overly complicated when
Fission is enabled. Looks like this test isn't really needed, so
we are removing it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6928411c8730
Enable BFCache for pages with beforeunload event listeners on Desktop r=smaug
https://hg.mozilla.org/integration/autoland/rev/782650de8717
Remove browser_navigateEvents.js test r=ochameau

Comment 6

[Cristian Tuns]

Backed out for causing causing wpt(without mochitest failures disregard the commit) failures on events.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /html/browsers/browsing-the-web/back-forward-cache/events.html | beforeunload - expected PRECONDITION_FAILED

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc9c97d475c2
Enable BFCache for pages with beforeunload event listeners on Desktop r=smaug
https://hg.mozilla.org/integration/autoland/rev/7fffe4e20ea8
Remove browser_navigateEvents.js test r=ochameau

Comment 8

[Cristian Tuns]

Backed out for causing wpt failures on back-forward-cache/events.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /html/browsers/browsing-the-web/back-forward-cache/events.html | beforeunload - expected PRECONDITION_FAILED

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d117e2934f55
Enable BFCache for pages with beforeunload event listeners on Desktop r=smaug
https://hg.mozilla.org/integration/autoland/rev/979db4220201
Remove browser_navigateEvents.js test r=ochameau

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d117e2934f55
https://hg.mozilla.org/mozilla-central/rev/979db4220201