Closed Bug 1741674 Opened 3 years ago Closed 3 years ago

Migrate active ticks and uri count Scalars to Glean

Categories

(Firefox :: General, task, P1)

task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: chutten, Assigned: chutten)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fog migration])

Attachments

(5 files)

This bug is about migrating the Scalars browser.engagement.active_ticks and browser.engagement.total_uri_count_normal_and_private_mode to Glean from Firefox Telemetry.

The specific migration that is called for is to leave the existing Telemetry calls for these probes in place (because they are important enough that we don't want to change them yet) and place Glean instrumentation calls immediately afterwards.

These metrics should be sent (temporarily) in both "baseline" and "metrics" pings to validate multi-ping ETL jobs like clients_daily.

Future work not in this bug:

  1. Deciding which of the two pings to send these metrics in permanently.
  2. Switching from explicit Telemetry APIs to using the Glean Interface For Firefox Telemetry
  3. Migrating any existing analyses of the probes using Firefox Telemetry-based datasets

This is a part of FOG Migration: the effort to move from Firefox Desktop Telemetry to Glean for data collections in Firefox Desktop. To learn more about FOG, please consult its documentation or ask questions on #telemetry:mozilla.org.

The FOG Migration spreadsheet including these metrics is here.

The Bugbug bot thinks this bug should belong to the 'Toolkit::Telemetry' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Telemetry
Product: Firefox → Toolkit

The original uri_counts bugs are in Firefox :: General, so that's where we should be, Bugbug. Instrumentation bugs live in the component under instrumentation.

Component: Telemetry → General
Product: Toolkit → Firefox

Dangit. These data collections are tested as mochitests. Which requires the "record but not upload" changes from bug 1737157 that keep bouncing. There's a hole in my bucket, dear Liza.

Depends on: 1737157
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad946f0db994
Add some FOG logging r=TravisLong
https://hg.mozilla.org/integration/autoland/rev/86c4f5f887cb
Advise in each metrics.yaml that we have docs for adding metrics r=TravisLong,nalexander
https://hg.mozilla.org/integration/autoland/rev/843e7cb6a325
Record active_ticks and uri_count in Glean as well as Telemetry r=TravisLong
https://hg.mozilla.org/integration/autoland/rev/931ed0e27a82
Expose a test_reset_fog to be able to reset Glean in tests r=TravisLong
https://hg.mozilla.org/integration/autoland/rev/aceb60c11e54
Use the new fog_test_reset_fog method to clear data before instrumentation tests r=janerik
Blocks: 1729026

Comment on attachment 9251688 [details]
Bug 1741674 - Use the new fog_test_reset_fog method to clear data before instrumentation tests r?janerik!

Beta/Release Uplift Approval Request

  • User impact if declined: Slower to get instrumentation of core KPI/KR metrics out of the full population meaning we need to keep Telemetry (and its warts) around longer.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1741674
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Well-tested, doesn't change existing instrumentation instead adding alongside. (And the other uplift (bug 1741674) is a comments-and-docs-only change)

Here's a prelim look at the instrumentation coming out of Nightly from this change: https://sql.telemetry.mozilla.org/queries/83058/source

  • String changes made/needed:
Attachment #9251688 - Flags: approval-mozilla-beta?
Attachment #9251595 - Flags: approval-mozilla-beta?
Attachment #9251597 - Flags: approval-mozilla-beta?
Attachment #9251598 - Flags: approval-mozilla-beta?
Attachment #9251687 - Flags: approval-mozilla-beta?

Comment on attachment 9251688 [details]
Bug 1741674 - Use the new fog_test_reset_fog method to clear data before instrumentation tests r?janerik!

Our last beta built last Thursday and we build 95 today.

Attachment #9251688 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9251595 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9251597 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9251598 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9251687 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
See Also: → 1755050
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: