1741688 - Update googletest to 1.11.0

Status: RESOLVED FIXED

(NSS :: Test, enhancement, P1)

Description

[Ján Jančár]

Steps to reproduce:

Running the NSS build with gcc 11.1.0 results in the error described in this issue in the googletest repository:
https://github.com/google/googletest/issues/3219

Expected results:

I suggest updating the bundled googletest library to 1.11.0 which has the fix for this issue. I will send a patch soon.

Comment 1

[Ján Jančár]

Attachment: Bug 1741688 - Update googletest to 1.11.0 r=bbeurdouche

Comment 2

[Benjamin Beurdouche [:beurdouche]]

https://hg.mozilla.org/projects/nss/rev/50f5a60523ca9df2baedacd23b97df9d24ef3a77

Comment 3

[Benjamin Beurdouche [:beurdouche]]

Thank you Ján!

Comment 4

[Benjamin Beurdouche [:beurdouche]]

Backed out for CI failures.
https://hg.mozilla.org/projects/nss/rev/1831460a6f34324c8a03d78e7f4a4cf2164353c0

Comment 5

[Benjamin Beurdouche [:beurdouche]]

nss-try before the backout:
https://treeherder.mozilla.org/jobs?repo=nss-try&revision=0ca2421af398589a32036dbc0bf547a74cd9b729

nss-try for the backout:
https://treeherder.mozilla.org/jobs?repo=nss-try&revision=84019f428138de0ea339e73ba653787f4c25e6d5

Looks like a few changes are needed... Ján, could you have a look?
I suggest keeping the current commit and add one on top with the changes to NSS.
(We can push to the CI for you if you need to test changes.)

Comment 6

[Martin Thomson [:mt:]]

I took a brief look at this and there is one easy problem and one hard one.

The easy one is that we instantiate tests for TlsAgentTestClient without defining a single TEST_P() for that class. Removing the instantiation works fine.

The hard one is that googletest doesn't compile with g++ 4.8. From what I can tell on their status page, c++11 was in the development process when gcc 4.8 shipped, so we've been coasting on that. I think that the right answer is to cut the C++ tests from our gcc 4.8 builds. We get most of the value from those tests running under a modern compiler, so losing this won't hurt that much. I'm happy to fix that up.

Comment 7

[Martin Thomson [:mt:]]

https://phabricator.services.mozilla.com/D131425?vs=518757&id=522756 shows the changes I needed to make
https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=afcb7b76e184 is the try run

Comment 8

[Ján Jančár]

Any movement on this? Still can't work on the library with modern gcc.

Comment 9

[Dennis Jackson]

Hi Ján,

Sorry this was left on the backburner after bouncing out due to CI failures. I've rebased your changes onto the latest NSS, fixed the issue and added a CI target for gcc-11. We should get your changes into the release next week.

Best,
Dennis

Comment 10

[Dennis Jackson]

https://hg.mozilla.org/projects/nss/rev/88249e154a2341e833e99e49c0446dd837071c7f