1741745 - Make '1proc' a test variant rather than a special cased e10s attribute

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

We currently run a bunch of '1proc' test tasks. These are currently handled by a special case e10s flag, but they should just be a standard variant.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1741745 - [taskgraph] Only validate parts of test schema that are actually needed in job/mozharness_test.py, r?jmaher!

Previously we we're validating the entire 'test_description_schema' again, even
though the vast majority of those keys were in fact no longer needed. This was
preventing us from ever removing keys from the 'task' object. Which I believe
is a good practice to keep things simple.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1741745 - [taskgraph] Create a '1proc' variant, r?jmaher!

This replaces the 'e10s' key with a standard variant in task configuration.

Depends on D133222

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1741745 - [taskgraph] Introduce a 'run-without-variant' key, r?jmaher!

Tasks that set this key to false will not run under the standard no variant
configuration.

This is needed to replace the 'e10s=false' case (i.e tasks that only run with
1proc like mochitest-chrome or mochitest-a11y.

Depends on D133224

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1741745 - [taskgraph] Stop setting 'e10s' attribute in test tasks, r?jmaher!

This attribute isn't necessary as e10s is the default. Instead consumers can
check if the string '1proc' appears in the unittest_variant attribute.

Depends on D133225

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/425cbdb97ae9
[taskgraph] Only validate parts of test schema that are actually needed in job/mozharness_test.py, r=jmaher
https://hg.mozilla.org/integration/autoland/rev/bdf342184019
[taskgraph] Create a '1proc' variant, r=jmaher
https://hg.mozilla.org/integration/autoland/rev/943d1b55ee62
[taskgraph] Introduce a 'run-without-variant' key, r=jmaher

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/16cdc671aa78
Port bug 1741745 - Make '1proc' a test variant rather than a special cased e10s attribute. rs=bustage-fix

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/425cbdb97ae9
https://hg.mozilla.org/mozilla-central/rev/bdf342184019
https://hg.mozilla.org/mozilla-central/rev/943d1b55ee62

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/851602939e83
[taskgraph] Stop setting 'e10s' attribute in test tasks, r=jmaher

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/851602939e83