1741854 - Prevent private messagehandler commands from being called via the WebSocket connection

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

MessageHandler modules might expose commands which are only meant to be used internally (mostly by other MessageHandler modules): for instance _subscribeEvent on the the log module: https://searchfox.org/mozilla-central/rev/bc5e79f3ae0f42cb4a6ebd05fc32f48a3829059d/remote/webdriver-bidi/modules/windowglobal/log.jsm#36

All those commands start with an "_", but other than this, they are identical to public commands which are supposed to be called by a WebDriver BiDi client over websocket.

Before we get an actual schema validation, we should prevent BiDi clients to directly call internal commands. For instance, this check could be performed at https://searchfox.org/mozilla-central/rev/bc5e79f3ae0f42cb4a6ebd05fc32f48a3829059d/remote/webdriver-bidi/WebDriverBiDiConnection.jsm#156

Comment 1

[Julian Descottes [:jdescottes]]

This should be relatively easy to implement, setting as mentored. I imagine we would test this via a wdspec test.
Not for milestone 2 though.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1741854 - [webdriver-bidi] Prevent internal methods from being called via the WebSocket connection.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aa2d8683e52
[webdriver-bidi] Prevent internal methods from being called via the WebSocket connection. r=webdriver-reviewers,jdescottes

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1aa2d8683e52