Closed Bug 1741872 Opened 3 years ago Closed 2 years ago

Add libtheora to list of libraries Updatebot can update

Categories

(Core :: Audio/Video, task, P1)

task

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: jewilde, Assigned: jewilde)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Theora is a great candidate for (semi)automatically vendoring updates from upstream via Updatebot.

A few notes about my first pass at this:

  • Since our last vendored update http://git.xiph.org is no longer up and the Xiph git repos have been (most likely around October 2020) moved to a GitLab instance at https://gitlab.xiph.org/xiph.
  • Commits upstream are infrequent so tracking commits should be low to no noise and our best option.
  • All of the local patches are no longer necessary except for possibly the one for 920992, which would depend on what version of gas we're using or if we still use that tool during build time. (See: https://sourceware.org/bugzilla/show_bug.cgi?id=12931)
  • I may have been overzealous in the excluding/removing files.
  • We need to find someone to set as maintainer.
Depends on: 1741873

Moving this to A/V....

Component: Mach Vendor & Updatebot → Audio/Video
Product: Developer Infrastructure → Core

Bryce could you direct us to whomever you think should 'own' libtheora? We'd like to enable it in Updatebot....

Flags: needinfo?(bvandyk)

Ack, holding NI and checking in with Media Team for appropriate owner.

Glandium do you know if we still utilize/support the GNU as in our build process and if so what version?

I'm wondering if we can remove the in tree diff related to 920992?
The alignment issue seems to have been patched a while back.

Flags: needinfo?(mh+mozilla)

(In reply to Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc) from comment #3)

Bryce could you direct us to whomever you think should 'own' libtheora? We'd like to enable it in Updatebot....

You can add me as the owner and I'll either try and wrangle issues myself or route them to other media folks.

Flags: needinfo?(bvandyk)

(In reply to June Wilde (she/her) [:jewilde] from comment #5)

Glandium do you know if we still utilize/support the GNU as in our build process and if so what version?

We do, but the specific version we use doesn't really matter. What matters is what downstreams might be using, and considering our minimum supported version of GCC is 7.1, which was released in 2017, the chances of someone building with binutils < 2.22 (released in 2011) are rather slim.

Flags: needinfo?(mh+mozilla)
Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88197349eaab
Add libtheora to libraries Updatebot can update; r=tjr
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: