1741931 - The background of various website pages and Firefox GUI items are dark with the certain Theme after landing patches from bug #1740089

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: The regression from bug #1740089.

The background of various website pages (like e.g. Bugzilla) and Firefox GUI items (like e.g. New Tab, Hamburger Menu) are dark with the certain Theme (like e.g. Virtualfox) after landing patches from bug #1740089.

It is worth to mention that when "System theme - auto" theme is used, the background of various website pages (like e.g. Bugzilla) and Firefox GUI items (like e.g. New Tab, Hamburger Menu) are not dark and have proper color.

STR:

1. Install Virtualfox theme from https://addons.mozilla.org/addon/virtualfox/
2. Notice that background of various website pages and Firefox GUI items are dark

mozillaregression-GUI points that this regression is caused by:

commit message:
Bug 1740089 - Fall back to frame (accentcolor) to determine toolbar theme. r=desktop-theme-reviewers,harry

Depends on D130669

Differential Revision: https://phabricator.services.mozilla.com/D130670

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug #1741931 - bad.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug #1741931 - good.png

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This is sorta expected because that theme has "frame": "#000000", "tab_background_text": "#000000" (so it's saying it's dark text with a dark background). I guess it might make more sense to look at the text color as that can't be covered up by an image.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1741931 - Use text color rather than background color to determine theme color scheme. r=harry,#desktop-theme-reviewers

It's easy for themes that have image backgrounds to have bogus
background colors.

Text color should give a better indication of the color-scheme since
it's always used, even with image backgrounds.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a065d19bef1
Use text color rather than background color to determine theme color scheme. r=harry,dao

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1a065d19bef1

Comment 7

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the issue with Fx 96.0a1(2021-11-18) Windows 7x64.
Verified as fixed with Fx 97.0a1 and Fx 96.0b4 Windows 7x64 and Win 10x64.

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

As OP, I'm also confirming that the bug is fixed, starting in Mozilla Firefox Nightly 96.0a1 (2021-11-20).
Thank you very much! \o/