Closed Bug 1741936 Opened 1 year ago Closed 4 months ago

Update shadow DOM + <dialog> focusing to latest spec

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: d, Assigned: sefeng)

Details

Attachments

(1 file)

The spec was previously not shadow DOM aware. In https://github.com/whatwg/html/pull/7285 we made it behave the same as delegatesFocus: they both "delegate focus" to either autofocus="" if it's specified on a (non-shadow-including) descendant, or the first focusable element among their shadow-including descendants if not.

Tests: https://github.com/web-platform-tests/wpt/pull/31523

NI myself for making the change

Flags: needinfo?(sefeng)
Type: defect → enhancement

After https://github.com/whatwg/html/pull/7361 and https://github.com/web-platform-tests/wpt/pull/31724 I believe this algorithm is now in good shape and implementable.

Assignee: nobody → sefeng
Attachment #9288406 - Attachment description: WIP: Bug 1741936 - Implement focus delegate algorithm → Bug 1741936 - Implement focus delegate algorithm r=emilio
Status: NEW → ASSIGNED

Sean, do you have cycles to finish this up now that the spec has been fixed up? Otherwise feel free to redirect the ni? to me and I can poke when available.

Flags: needinfo?(sefeng)
Flags: needinfo?(sefeng)

I should be able to update it this week, will let you know if I can't do it.

Pushed by sefeng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0e9dd86db73
Implement focus delegate algorithm r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36449 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Flags: needinfo?(sefeng)
Upstream PR was closed without merging
Upstream PR merged by jgraham
You need to log in before you can comment on or make changes to this bug.