1741936 - Update shadow DOM + <dialog> focusing to latest spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Domenic Denicola]

The spec was previously not shadow DOM aware. In https://github.com/whatwg/html/pull/7285 we made it behave the same as delegatesFocus: they both "delegate focus" to either autofocus="" if it's specified on a (non-shadow-including) descendant, or the first focusable element among their shadow-including descendants if not.

Tests: https://github.com/web-platform-tests/wpt/pull/31523

Comment 1

[Sean Feng [:sefeng211]]

NI myself for making the change

Comment 2

[Domenic Denicola]

After https://github.com/whatwg/html/pull/7361 and https://github.com/web-platform-tests/wpt/pull/31724 I believe this algorithm is now in good shape and implementable.

Comment 3

[Sean Feng [:sefeng211]]

Attachment: Bug 1741936 - Implement focus delegate algorithm r=emilio

Spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-delegate

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Sean, do you have cycles to finish this up now that the spec has been fixed up? Otherwise feel free to redirect the ni? to me and I can poke when available.

Comment 5

[Sean Feng [:sefeng211]]

I should be able to update it this week, will let you know if I can't do it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0e9dd86db73
Implement focus delegate algorithm r=emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36449 for changes under testing/web-platform/tests

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d0e9dd86db73

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham