1742006 - Minor clean up of Union methods in Rect types

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Please see the commit message of the upcoming patches.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1742006 - Remove two unused nsRect union methods.

nsRect's Union ond UnionEdges are already saturating operations, so we don't
need these two methods.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1742006 - Fix documents of rect types' Union and SaturatingUnion, and add a test.

The documents of Union and SaturatingUnion promise that |this| will be return
when both rects are empty, but the current implementation returns aRect instead.

This patch fixes the documents and added a test case.

Depends on D131567

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89a712ca5342
Remove two unused nsRect union methods. r=gfx-reviewers,sotaro
https://hg.mozilla.org/integration/autoland/rev/b9329e4be718
Fix documents of rect types' Union and SaturatingUnion, and add a test. r=gfx-reviewers,mstange

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/89a712ca5342
https://hg.mozilla.org/mozilla-central/rev/b9329e4be718