Closed Bug 174221 Opened 21 years ago Closed 21 years ago
field names should be l10n in user-errors
.html .tmpl called by Add Estimated, Actual, Remaining Time Fields
bug 24789 (http://bugzilla.mozilla.org/show_bug.cgi?id=24789) added those user errors: + [% ELSIF error == "need_positive_number" %] + [% title = "Positive Number Required" %] + [% field %] requires a positive number. + [% ELSIF error == "value_out_of_range" %] + [% title = "Value Out Of Range" %] + Value is out of range for field [% variable %]. where the "variable" and the "field" is a hard coded string. This makes the translation of this string rather hard. How about using field-descs.html.tmpl for this purpose? Additionallay a "The <em>estimated Time</em> requires a positive number." is more verbose than a "estimated_time requires a positive number." even in English ;-)
Yes - the error templates should roll in global/field-descs.html.tmpl, and any field names should be translated. Gerv
Comment on attachment 102889 [details] [diff] [review] Patch v.1 Looks ok to me. r=burnus
Attachment #102889 - Flags: review+
r=gerv. Checked in. Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.157; previous revision: 1.156 done Checking in template/en/default/global/field-descs.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.html.tmpl,v <-- field-descs.html.tmpl new revision: 1.2; previous revision: 1.1 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.19; previous revision: 1.18 done Gerv
Closing, since Gerv checked it in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment on attachment 102889 [details] [diff] [review] Patch v.1 (Close pending request. This has been checked in and twice reviewed.)
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.