1742437 - Factor out common ScriptLoadRequest for use in Worker and DOM

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Comment 1

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - Split ScriptLoadRequest into ScriptLoadRequestBase and DOM ScriptLoadRequest; r=jonco

Comment 2

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - Split ScriptLoadRequest into ScriptLoadRequest and DOMScriptLoadContext; r=jonco

Depends on D134040

Comment 3

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - Ensure that offthread code is only in dom scriptloader; r=jonco

Depends on D134041

Comment 4

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - move mElement from ScriptFetchOptions to DOMScriptLoadContext; r=jonco

Depends on D136741

Comment 5

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco

Depends on D136742

Comment 6

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - move mWebExtGlobal from ScriptLoadRequest to DOMScriptLoadContext; r=jonco

Depends on D136743

Comment 7

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - move mLineNo from ScriptLoadRequest to DOMScriptLoadContext; r=jonco

Depends on D136744

Comment 8

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - clean up DOMScriptLoadRequest creation; r=jonco

Depends on D136745

Comment 9

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - Create DOM specific Module Loader; r=jonco,smaug

Depends on D136746

Comment 10

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - move FireScript.* methods from DOMScriptLoadContext to ScriptLoader;r=jonco

Depends on D136746

Comment 11

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - move DOM module loader into own file; r=jonco,smaug

Depends on D137298

Comment 12

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - Move module loader files into a central folder; r=jonco,smaug

Depends on D137531

Comment 13

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - move DOM script context into own file and rename it; r=jonco,smaug

Depends on D137531

Comment 14

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1742437 - re-scope all generic module/script loader files under js/loader; r=jonco,smaug

Depends on D137532

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ac6d9d26e2b
Split ScriptLoadRequest into ScriptLoadRequest and DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/a50f60a612d3
move mElement from ScriptFetchOptions to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/0a5f61274aed
move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/9355004c7f6a
move mWebExtGlobal from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/729c48e34d6b
move mLineNo from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/8b970fb6e4e6
clean up DOMScriptLoadRequest creation; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/c0bd1d29be62
move FireScript.* methods from DOMScriptLoadContext to ScriptLoader;r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/f29451ea18dc
Create DOM specific Module Loader; r=jonco
https://hg.mozilla.org/integration/autoland/rev/3a34d557d474
move DOM module loader into own file; r=jonco
https://hg.mozilla.org/integration/autoland/rev/7e54a223001d
move DOM script context into own file and rename it; r=jonco
https://hg.mozilla.org/integration/autoland/rev/a48aff5f2555
Move module loader files into a central folder; r=jonco
https://hg.mozilla.org/integration/autoland/rev/7d5683180ac3
re-scope all generic module/script loader files under js/loader; r=jonco

Comment 16

[Norisz Fay [:noriszfay]]

Backed out for causing Bp-hybrid bustages on ModuleLoader.obj

Backout link

Push with failures

Failure log

Failure line(s): gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:660: ModuleLoader.obj] Error 1

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46d45c7bae2f
Split ScriptLoadRequest into ScriptLoadRequest and DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/0a3d9301244b
move mElement from ScriptFetchOptions to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/c33b42cabd55
move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/ea775927f4ab
move mWebExtGlobal from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/130bd544f3f4
move mLineNo from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/bf411e44f622
clean up DOMScriptLoadRequest creation; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/467f757b6580
move FireScript.* methods from DOMScriptLoadContext to ScriptLoader;r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/e3fe772947bf
Create DOM specific Module Loader; r=jonco
https://hg.mozilla.org/integration/autoland/rev/22649272ffae
move DOM module loader into own file; r=jonco
https://hg.mozilla.org/integration/autoland/rev/967e68ed5f56
move DOM script context into own file and rename it; r=jonco
https://hg.mozilla.org/integration/autoland/rev/0527d227c6b6
Move module loader files into a central folder; r=jonco
https://hg.mozilla.org/integration/autoland/rev/c11cffaded9c
re-scope all generic module/script loader files under js/loader; r=jonco

Comment 18

[Sandor Molnar[:smolnar]]

Backed out 12 changesets (bug 1742437) for causing build bustages in dom/script/ScriptTrace.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/ce337b4435dd8364e78208daaca3592409c4554c

Push with failures

Failure log

INFO -  In file included from /builds/worker/checkouts/gecko/dom/script/ModuleLoader.cpp:8:
[task 2022-02-18T13:08:13.141Z] 13:08:13    ERROR -  /builds/worker/checkouts/gecko/dom/script/ScriptTrace.h:40:17: error: unused function 'TestingDispatchEvent' [-Werror,-Wunused-function]
[task 2022-02-18T13:08:13.141Z] 13:08:13     INFO -  static nsresult TestingDispatchEvent(nsIScriptElement* aScriptElement,

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d52858ae58d2
Split ScriptLoadRequest into ScriptLoadRequest and DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/a71a2a98b6bc
move mElement from ScriptFetchOptions to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/835c89a0687b
move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/1751a35aae40
move mWebExtGlobal from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/ef9a1bd41a68
move mLineNo from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/309f151e76bc
clean up DOMScriptLoadRequest creation; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/e96ec49e3e04
move FireScript.* methods from DOMScriptLoadContext to ScriptLoader;r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/98d6cb49f4fd
Create DOM specific Module Loader; r=jonco
https://hg.mozilla.org/integration/autoland/rev/0b3f0972e002
move DOM module loader into own file; r=jonco
https://hg.mozilla.org/integration/autoland/rev/7ecc4f9b20ad
move DOM script context into own file and rename it; r=jonco
https://hg.mozilla.org/integration/autoland/rev/85fd9fc9cffa
Move module loader files into a central folder; r=jonco
https://hg.mozilla.org/integration/autoland/rev/b8ecf23519c9
re-scope all generic module/script loader files under js/loader; r=jonco

Comment 20

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d52858ae58d2
https://hg.mozilla.org/mozilla-central/rev/a71a2a98b6bc
https://hg.mozilla.org/mozilla-central/rev/835c89a0687b
https://hg.mozilla.org/mozilla-central/rev/1751a35aae40
https://hg.mozilla.org/mozilla-central/rev/ef9a1bd41a68
https://hg.mozilla.org/mozilla-central/rev/309f151e76bc
https://hg.mozilla.org/mozilla-central/rev/e96ec49e3e04
https://hg.mozilla.org/mozilla-central/rev/98d6cb49f4fd
https://hg.mozilla.org/mozilla-central/rev/0b3f0972e002
https://hg.mozilla.org/mozilla-central/rev/7ecc4f9b20ad
https://hg.mozilla.org/mozilla-central/rev/85fd9fc9cffa
https://hg.mozilla.org/mozilla-central/rev/b8ecf23519c9