1742462 - New thin line displayed between tab bar and tool bar with Firefox Color theme

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Haik Aftandilian [:haik]]

Attachment: Screenshot showing unexpected line between tab bar and tool bar

On macOS running Nightly, recently my theme created with the Firefox Color extension started being displayed with a thin line between the tab bar and tool bar. See screenshot.

Here's the mozregression range.
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5a1d71c887d910acfb6ccc459450dc41ac35d971&tochange=7c5a0fa01f7cda701dcec516a405bbdace28d173

[Edit] Updated regression range identifies bug 1740788.
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ac52da65f48fb66f9df0c93a33fb57ba3bb68465&tochange=965bf155a9db49ce7ec1533b3b8eee2901a79d4e

Comment 1

[:Gijs (he/him)]

Emilio, I expect this wasn't intentional?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I don't think that patch can cause the regression? The pref was already true on Nightly, and that patch only made it ride the trains, so I'm confused. Also flipping it back off doesn't change behavior for me, so Haik are you sure the regression range is accurate?

Comment 3

[Haik Aftandilian [:haik]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

I don't think that patch can cause the regression? The pref was already true on Nightly, and that patch only made it ride the trains, so I'm confused. Also flipping it back off doesn't change behavior for me, so Haik are you sure the regression range is accurate?

I'll re-run mozregression. I had to skip some builds, but I didn't think that compromised the result.

Comment 4

[Haik Aftandilian [:haik]]

(In reply to Haik Aftandilian [:haik] from comment #3)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

I don't think that patch can cause the regression? The pref was already true on Nightly, and that patch only made it ride the trains, so I'm confused. Also flipping it back off doesn't change behavior for me, so Haik are you sure the regression range is accurate?

I'll re-run mozregression. I had to skip some builds, but I didn't think that compromised the result.

Yes, the first regression range was wrong.

Updated regression range identifies bug 1740788:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ac52da65f48fb66f9df0c93a33fb57ba3bb68465&tochange=965bf155a9db49ce7ec1533b3b8eee2901a79d4e

@Dao, could you take a look?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1576289

Comment 6

[Dão Gottwald [:dao]]

This border was already present on Linux and Windows but implemented inconsistently. We've fixed that, which is why you now get the border on macOS too. You can make your theme set toolbar_top_separator to transparent (or any other color) if you wish.