1742533 - Does WaitForGPU need to be added to RenderCompositorEGL?

Status: RESOLVED INVALID

(Core :: Graphics: WebRender, defect)

Description

[Darkspirit]

https://chat.mozilla.org/#/room/#gfx:mozilla.org/$4Kb_Ce5swAe9kWC3PX9F-MCCMwdV4DgsAIsvD_d0QiU

yeah, we currently wait on the fence in RenderCompositorANGLE::WaitForGPU() and RenderCompositorNativeOGL::WaitForGPU()
not sure if there's an equivalent for that on linux

There is some Android-only fence in a different method: https://searchfox.org/mozilla-central/rev/55a826a9ef74e92988e56cd9615d4fc6a470695e/gfx/webrender_bindings/RenderCompositorEGL.cpp#101-107

Or is the Dmabuf fence enough for Linux? (bug 1741997)

Comment 1

[Jan Alexander Steffens [:heftig]]

The "DMABuf fence" is using the same EGL_ANDROID_native_fence_sync extension the MOZ_WIDGET_ANDROID code in RenderCompositorEGL does. Maybe the latter just needs to be extended to GTK.

(Seems DMABuf also provides implicit fences. I wonder why those don't seem to get used.)

Comment 2

[Jamie Nicol [:jnicol]]

The android fence is used for recycling hardware buffers, not back pressure. And we don't actually use hardware buffers, so we don't actually create those fences