1742559 - Parsing invalid MIDI messages crashes the content process

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gabriele Svelto [:gsvelto]]

I stumbled upon this by testing my implementation. I tried sending some junk messages (e.g. "foo") and discovered that we'd crash here accessing a NULL pointer. The invalid message meant that we'd never reach this point where the pointer is initialized. I'll write a test-case for this.

Comment 1

[Gabriele Svelto [:gsvelto]]

Chromium has a nice test for this kind of stuff. I should write a similar one.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1742559 - Adjust MIDI message validation and add relevant tests r=padenot

Depends on D131351

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f557e1c37091
Adjust MIDI message validation and add relevant tests r=padenot

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f557e1c37091

Comment 5

[Gabriele Svelto [:gsvelto]]

Comment on attachment 9255909 [details]
Bug 1742559 - Adjust MIDI message validation and add relevant tests r=padenot

Beta/Release Uplift Approval Request

• User impact if declined: Firefox will crash if invalid MIDI messages are sent to a device
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Web MIDI is still pref'd off
• String changes made/needed: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9255909 [details]
Bug 1742559 - Adjust MIDI message validation and add relevant tests r=padenot

Approved for 97.0b3.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fed6019996e4