1742573 - Permanent spidermonkey non-unified js/src/wasm/WasmBCMemory.cpp:337:20: error: unused function 'ToValidIndex' [-Werror,-Wunused-function] when Gecko 96 merges to Beta on 2021-12-06

Status: VERIFIED FIXED

(Core :: JavaScript: WebAssembly, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

[task 2021-11-23T11:13:27.784Z]  2:22.15 /builds/worker/checkouts/gecko/js/src/wasm/WasmBCMemory.cpp:337:20: error: unused function 'ToValidIndex' [-Werror,-Wunused-function]
[task 2021-11-23T11:13:27.785Z]  2:22.15 static inline void ToValidIndex(MacroAssembler& masm, RegI64 ptr) {}
[task 2021-11-23T11:13:27.785Z]  2:22.15                    ^
[task 2021-11-23T11:13:27.785Z]  2:22.15 1 error generated.

Comment 1

[Lars T Hansen [:lth]]

Needs an ifdef MEMORY64 presumably. (But we really should fix the unused-static-inline-function warning, which is pretty absurd.)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 3

[Zhao Jiazhong]

Attachment: Bug 1742573 - Fix build issue caused by unused function 'ToValidIndex'. r=lth

Comment 4

[Zhao Jiazhong]

I'm not sure how to run the test now, it seems like I need to setup a ssh key, is it accessible to every contributer?
Anyway, I think lth is right, we should define the function only when MEMORY64 is enabled, so I just fix it this way.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbd1ffd74b54
Fix build issue caused by unused function 'ToValidIndex'. r=lth

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Every contributor can access the test ("Try") server. See

• https://firefox-source-docs.mozilla.org/tools/try/index.html
• https://firefox-source-docs.mozilla.org/tools/try/configuration.html
• https://www.mozilla.org/en-US/about/governance/policies/commit/

Comment 7

[Zhao Jiazhong]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #6)

Every contributor can access the test ("Try") server. See

• https://firefox-source-docs.mozilla.org/tools/try/index.html
• https://firefox-source-docs.mozilla.org/tools/try/configuration.html
• https://www.mozilla.org/en-US/about/governance/policies/commit/

Thanks for your information, I just applied for the commit access.

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fbd1ffd74b54

Comment 9

[Cristian Tuns]

The patch is working just fine on beta simulation.

• Simulation

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in today's central-as-beta simulation.