Closed
Bug 1742594
Opened 2 years ago
Closed 2 years ago
Handle arguments objects in HasPropIRGenerator
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
https://phabricator.services.mozilla.com/D131734 contained the following code:
var hint = 1 in arguments ? arguments[1] : sync;
We don't yet attach an IC for the in operator on arguments objects, so that code would have resulted in slow execution.
I've verified in a browser build that attaching an IC for in on arguments objects also hits real-world usage. And there are also some hits on Speedometer.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D131917
|
||
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P1
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ec9ba8ba820a Part 1: Optimise 'in' operator for arguments. r=iain https://hg.mozilla.org/integration/autoland/rev/8d5eba1637f3 Part 2: Enable some commented-out tests. r=iain
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ec9ba8ba820a
https://hg.mozilla.org/mozilla-central/rev/8d5eba1637f3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•