1742594 - Handle arguments objects in HasPropIRGenerator

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[André Bargull [:anba]]

https://phabricator.services.mozilla.com/D131734 contained the following code:

var hint = 1 in arguments ? arguments[1] : sync;

We don't yet attach an IC for the in operator on arguments objects, so that code would have resulted in slow execution.

I've verified in a browser build that attaching an IC for in on arguments objects also hits real-world usage. And there are also some hits on Speedometer.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1742594 - Part 1: Optimise 'in' operator for arguments. r=iain!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1742594 - Part 2: Enable some commented-out tests. r=iain!

Depends on D131917

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec9ba8ba820a
Part 1: Optimise 'in' operator for arguments. r=iain
https://hg.mozilla.org/integration/autoland/rev/8d5eba1637f3
Part 2: Enable some commented-out tests. r=iain

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ec9ba8ba820a
https://hg.mozilla.org/mozilla-central/rev/8d5eba1637f3