Closed
Bug 1742628
Opened 4 years ago
Closed 4 years ago
Remove unnecessary includes to js/src/frontend outside of js/src/frontend
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
96 Branch
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(4 files)
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
This file was added about the same time when non-unified builds were enabled
for all of js/src, so by accident it didn't get updated to work outside of
unified builds. (Non-unified builds are needed to produce correct IWYU results.)
Assignee | ||
Comment 2•4 years ago
|
||
Remove unnecessary includes to js/src/frontend as determined by IWYU.
Depends on D131921
Assignee | ||
Comment 3•4 years ago
|
||
And remove some outdated comments referring to the previous trace list
managed by the parser.
Depends on D131922
Assignee | ||
Comment 4•4 years ago
|
||
These methods aren't used anymore.
Depends on D131923
Updated•4 years ago
|
Priority: -- → P1
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6e89708bcbf1
Part 1: Enable non-unified builds for js/src/util. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a8bab08b3739
Part 2: Remove unnecessary includes to js/src/frontend. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/49bbe43f9c6e
Part 3: Move AtomVector and FunctionBoxVector. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/03623978ef70
Part 4: Remove unused JSScript methods. r=tcampbell
Comment 6•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6e89708bcbf1
https://hg.mozilla.org/mozilla-central/rev/a8bab08b3739
https://hg.mozilla.org/mozilla-central/rev/49bbe43f9c6e
https://hg.mozilla.org/mozilla-central/rev/03623978ef70
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•