1742722 - Move CompositorScreenshot markers to the main thread

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Florian Quèze [:florian]]

It's annoying to lose screenshots when the Renderer thread is not in the list of sampled threads, or when that thread is sanitized out at upload time.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1742722 - Move CompositorScreenshot markers to the main thread, r=mstange.

Comment 2

[Julien Wajsberg [:julienw]]

Good idea !
I just want to mention that if there's a performance issue doing this in Firefox (because of the size of the data possibly?), it's always possible to do a frontend patch adressing this problem.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thanks for the offer Julien, but I think the problem is really in Firefox: If the Renderer thread is not selected for profiling, the screenshot markers won't even be present in the output json profile!
This patch only targets the markers to appear in the main thread data, it won't add any work on the actual main thread during profiling.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6d7fdfdaca7
Move CompositorScreenshot markers to the main thread, r=mstange.

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e6d7fdfdaca7