1742752 - GeckoDriver.setScreenOrientation should use Screen Orientation API instead of deprecated mozLockOrientation

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P3)

Description

[Makoto Kato [:m_kato]]

https://searchfox.org/mozilla-central/rev/aa8c75b83f636948f708986173965c84cae8c25f/remote/marionette/driver.js#2272

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Do you have a link to the screen orientation API? Also do you want to mentor this bug? Note that we usually do not use good-first-bug in this project due to it's complexity. Maybe we can have it as a normal mentored bug?

Comment 2

[Makoto Kato [:m_kato]]

Spec: https://www.w3.org/TR/screen-orientation/. And GeckoDriver.prototype.getScreenOrientation uses old deprecated API too.

we usually do not use good-first-bug in this project

OK, I remove good-first-bug

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks. So when distilling this information the following changes need to be done:

1. Update WebDriver:getScreenOrientation to no longer use screen.mozOrientation but screen.orientation. The value to be returned should then be screen.orientation.type.

2. Update WebDriver:setScreenOrientation to use screen.orientation.lock() to lock the screen to a specific orientation. This call returns a Promise that we would have to await for.

To note here is that the specification mentions that some pre-conditions might have to be fulfilled first, like switching into fullscreen. If we have to do that, then it would have to be added before the call to lock().

More details in how to get started can be found at https://firefox-source-docs.mozilla.org/testing/marionette/index.html

Comment 4

[sanket.sarmalkar2002]

is anyone working on this . if not can I work?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hi Sanket. It's great to see your interest! So far we don't have anyone working on it. As such you can get started. See my last comment for details in how to get started with Marionette and what needs to be done. If you have questions don't hesitate to ask. Thanks!

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1742752 - GeckoDriver.setScreenOrientation should use Screen Orientation API. r=#webdriver-reviewers

mozLockOrientation is deprecated and it always returns false.
We should use standard API (it is still turned off as default).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea5fa5e28a56
GeckoDriver.setScreenOrientation should use Screen Orientation API. r=webdriver-reviewers,whimboo

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ea5fa5e28a56