The “Go to existing entry” link from the duplicate notification cannot be accessed with keyboard navigation
Categories
(Firefox :: about:logins, defect, P3)
Tracking
()
People
(Reporter: srosu, Assigned: janvi01, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(2 files)
GoToExistingEntry_NotFocused.gif
[Affected versions]:
- Firefox Release 94.0.1 (Build ID:20211103134640)
- Firefox Beta 95.0b11 (Build ID: 20211123190150)
- Firefox Nightly 96.0a1 (Build ID: 20211123215113)
[Affected Platforms]:
- macOS 11.6
- Windows 10 x64
- Windows 11 x64
- Ubuntu 20.04 x64
[Prerequisites]:
- Have the Firefox browser installed.
- Have a Firefox profile with at least one saved login opened.
[Steps to reproduce]:
- Navigate to the “about:logins: page.
- Click the “Create New Login" button.
- Fill the fields with the same website and credentials as another entry.
- Click the "Save" button.
- Press the “Tab” key until the “Go to existing entry” link is focused.
- Observe the behavior.
[Expected result]:
- The “Go to existing entry” link is focused.
[Actual result]:
- The “Go to existing entry” link cannot be focused.
[Notes]:
- Attached is a screen recording of the issue.
|
||
Updated•2 years ago
|
|
|
||
Comment 2•2 years ago
|
||
Janvi thank you, please attach a patch so we can review it.
In case you need it, here is a link to Firefox Contributors’ Quick Reference¶
Ask questions here if you need help :)
|
Assignee | |
Comment 3•2 years ago
|
||
(In reply to Sergey Galich from comment #2)
Janvi thank you, please attach a patch so we can review it.
In case you need it, here is a link to Firefox Contributors’ Quick Reference¶
Ask questions here if you need help :)
If you could point me to the exact file/folder where code related to this can be found?
I have cloned mozilla-unified.
Thanks!
|
|
Assignee | |
Comment 4•2 years ago
|
||
Hey, I have found
Go to existing entry i.e. duplicate link in aboutLogins.html
<div class="error-message">
<span class="error-message-text" data-l10n-id="about-logins-error-message-default"></span>
<span class="error-message-link">
<a data-l10n-name="duplicate-link" href=""></a>
</span>
</div>
Adding a tabindex="0" in the a tag here would solve the problem.
(In reply to Sergey Galich from comment #2)
Janvi thank you, please attach a patch so we can review it.
In case you need it, here is a link to Firefox Contributors’ Quick Reference¶
Ask questions here if you need help :)
|
|
||
Comment 5•2 years ago
|
||
(In reply to Janvi Bajoria [:janvi01] from comment #4)
Adding a
tabindex="0"in theatag here would solve the problem.
Looks like you are on the right path! Please submit a patch for review.
|
|
Assignee | |
Comment 6•2 years ago
|
||
|
|
Assignee | |
Comment 7•2 years ago
|
||
(In reply to Sergey Galich from comment #5)
(In reply to Janvi Bajoria [:janvi01] from comment #4)
Adding a
tabindex="0"in theatag here would solve the problem.Looks like you are on the right path! Please submit a patch for review.
I have submitted it, Please review it.
Thanks!
|
|
||
Comment 8•2 years ago
|
||
Thank you Janvi, I've tested patch and it looks good!
Pushed by sgalich@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da1ca12d11df Go to existing entry link navigable. r=sgalich
|
|
Assignee | |
Comment 10•2 years ago
|
||
(In reply to Sergey Galich from comment #8)
Thank you Janvi, I've tested patch and it looks good!
Thanks :)
|
||
Comment 11•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 12•2 years ago
|
||
(In reply to Sergey Galich from comment #8)
Thank you Janvi, I've tested patch and it looks good!
Hey, I have found that the "Sign in to sync" button and menu button beside it on the same page are also not navigable with the keyboard, it is navigable only once and after that, it isn't.
Should I create a new bug?
|
|
Assignee | |
Updated•2 years ago
|
|
|
||
Comment 13•2 years ago
|
||
(In reply to Janvi Bajoria [:janvi01] from comment #12)
(In reply to Sergey Galich from comment #8)
Thank you Janvi, I've tested patch and it looks good!
Hey, I have found that the "Sign in to sync" button and menu button beside it on the same page are also not navigable with the keyboard, it is navigable only once and after that, it isn't.
Should I create a new bug?
Yes, please create a new bug, it will be easier to track all the patches this way.
|
Reporter | |
Comment 14•2 years ago
|
||
I‘ve just verified this issue using the latest Firefox Nightly 99.0a1 (Build ID: 20220220215821) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.
- It seems that this issue is still reproducible. While verifying, I have observed that the “Go to an existing entry” link can be focused by pressing the “Tab” key only after clicking the notification area or focusing the "Search" bar. However even if you managed to focus the link, nothing happens after pressing the "Enter" or "Space" key, the “Discard unsaved changes?” pop-up is not displayed.
@Sergey, considering these can we reopen this bug or should we log a new one? Thanks!
|
|
||
Comment 15•2 years ago
|
||
Simona, good catch! I'd recommend to open a new bug. This was about not being able to focus link, what you describe is not being able to activate link with keyboard (we really need to become keyboard friendly).
|
|
||
Comment 16•2 years ago
|
||
Simona, sorry, I've forgot to address first part of your report - TAB is not always working to focus "Got to existing entry?" - this is not specific to that link, it's a problem with whole upper area. I don't know if we have bug already, but please feel free to file a new one - we should clean up focus management on the whole page.
|
||
Updated•2 years ago
|
|
|
Reporter | |
Comment 17•2 years ago
|
||
Thanks, Sergey for your replies. I logged a different bug (Bug 1757156) based on comment 15 for the activate part, and also left a comment on Bug 1756387 mentioning that the issue is also reproducible for the "Go to existing entry?" link.
- Considering these I’m marking this issue as Verified fixed.
| Comment hidden (obsolete) |
Description
•