1742788 - For loading search-config, enable reloading a collection from the local dump if it is newer than the database

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Bug 1717068 has enabled reloading a collection from the local dump if that dump is newer than what is in the database.

One benefit of this, is that if remote settings is unable to update for any reason then we'll still reload the collection when an application update is applied.

The check is performed via timestamps comparison, the timestamps for the local dump are in a separate file so the main (big) dump does not have to be parsed. Therefore I don't think there would be any significant performance impact here so I think it is good to enable for better stability.

Comment 1

[Rob Wu [:robwu]]

Please add me as a reviewer.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1742788 - Enable loading from the local dump if it is newer for the search-config remote settings collection. r?robwu!,mkaply!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa7ec49d934
Enable loading from the local dump if it is newer for the search-config remote settings collection. r=robwu,daleharvey

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5fa7ec49d934

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 9252313 [details]
Bug 1742788 - Enable loading from the local dump if it is newer for the search-config remote settings collection. r?robwu!,mkaply!

Beta/Release Uplift Approval Request

• User impact if declined: Old search settings are used when mint is upgraded.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Already working with QA for testing.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): automated test
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9252313 [details]
Bug 1742788 - Enable loading from the local dump if it is newer for the search-config remote settings collection. r?robwu!,mkaply!

Approved for a 95 dot release, thanks.

Comment 7

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/c1fae07a3ae4

Comment 8

[Adrian Florinescu [:aflorinescu]]

Already tested on 95 (here) and since this is riding 95.0.1, updating flags.

Comment 9

[Adrian Florinescu [:aflorinescu]]

Verified on Linux Mint Cinnamon 20.2, Windows 10, Mac 11 using 97.0a1 (2022-01-05) and RC 96.0 2022-01-03.