Closed Bug 1742826 Opened 3 years ago Closed 3 years ago

Perma toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature network.cookie.sameSite.laxByDefault should match | when Gecko 96 merges to Beta on 2021

Categories

(Toolkit :: FeatureGate, defect)

Product:
Toolkit
Component:
FeatureGate
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
thunderbird_esr91 --- unaffected
firefox-esr91 --- unaffected
firefox94 --- unaffected
firefox95 --- unaffected
firefox96 + verified

People

(Reporter: ctuns, Assigned: aryx)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1742826 - adjust FeatureGate data: network.cookie.sameSite.* are 'true' across channels since the changes in bug 1617609. r=ckerschb
48 bytes, text/x-phabricator-request
Details | Review

[Tracking Requested - why for this release]:

Central-as-beta simulation:
How to run these simulations:

Failure log:

[task 2021-11-24T15:18:18.167Z] 15:18:18     INFO -  TEST-PASS | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature browser.startup.homepage.abouthome_cache.enabled should match runtime value. - false == false
[task 2021-11-24T15:18:18.167Z] 15:18:18  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature network.cookie.sameSite.laxByDefault should match runtime value. - false == true
[task 2021-11-24T15:18:18.168Z] 15:18:18     INFO -  /opt/worker/tasks/task_163776500640799/build/tests/xpcshell/tests/toolkit/components/featuregates/test/unit/test_FeatureGate.js:testAllDefaultsMatchSettings:440
[task 2021-11-24T15:18:18.168Z] 15:18:18     INFO -  /opt/worker/tasks/task_163776500640799/build/tests/xpcshell/head.js:_do_main:240
[task 2021-11-24T15:18:18.168Z] 15:18:18     INFO -  /opt/worker/tasks/task_163776500640799/build/tests/xpcshell/head.js:_execute_test:605
[task 2021-11-24T15:18:18.168Z] 15:18:18     INFO -  -e:null:1
[task 2021-11-24T15:18:18.168Z] 15:18:18     INFO -  exiting test
[task 2021-11-24T15:18:18.169Z] 15:18:18     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2021-11-24T15:18:18.169Z] 15:18:18     INFO -  _abort_failed_test@/opt/worker/tasks/task_163776500640799/build/tests/xpcshell/head.js:876:20
[task 2021-11-24T15:18:18.169Z] 15:18:18     INFO -  do_report_result@/opt/worker/tasks/task_163776500640799/build/tests/xpcshell/head.js:977:5
[task 2021-11-24T15:18:18.169Z] 15:18:18     INFO -  Assert<@/opt/worker/tasks/task_163776500640799/build/tests/xpcshell/head.js:75:21
[task 2021-11-24T15:18:18.169Z] 15:18:18     INFO -  proto.report@resource://testing-common/Assert.jsm:228:10
[task 2021-11-24T15:18:18.170Z] 15:18:18     INFO -  equal@resource://testing-common/Assert.jsm:270:8
[task 2021-11-24T15:18:18.170Z] 15:18:18     INFO -  testAllDefaultsMatchSettings@/opt/worker/tasks/task_163776500640799/build/tests/xpcshell/tests/toolkit/components/featuregates/test/unit/test_FeatureGate.js:440:12
[task 2021-11-24T15:18:18.170Z] 15:18:18     INFO -  _do_main@/opt/worker/tasks/task_163776500640799/build/tests/xpcshell/head.js:240:6
[task 2021-11-24T15:18:18.170Z] 15:18:18     INFO -  _execute_test@/opt/worker/tasks/task_163776500640799/build/tests/xpcshell/head.js:605:5
[task 2021-11-24T15:18:18.171Z] 15:18:18     INFO -  @-e:1:1
[task 2021-11-24T15:18:18.171Z] 15:18:18     INFO -  exiting test
[task 2021-11-24T15:18:18.171Z] 15:18:18     INFO -  <<<<<<<
[task 2021-11-24T15:18:18.171Z] 15:18:18     INFO -  INFO | Result summary:
[task 2021-11-24T15:18:18.171Z] 15:18:18     INFO -  INFO | Passed: 1635
[task 2021-11-24T15:18:18.171Z] 15:18:18  WARNING -  INFO | Failed: 1
[task 2021-11-24T15:18:18.171Z] 15:18:18  WARNING -  One or more unittests failed.
[task 2021-11-24T15:18:18.172Z] 15:18:18     INFO -  INFO | Todo: 4
[task 2021-11-24T15:18:18.172Z] 15:18:18     INFO -  INFO | Retried: 2
[task 2021-11-24T15:18:18.172Z] 15:18:18     INFO -  SUITE-END | took 256s
[task 2021-11-24T15:18:18.172Z] 15:18:18     INFO -  Node moz-http2 server shutting down ...
[task 2021-11-24T15:18:18.172Z] 15:18:18     INFO -  http3Server server shutting down ...
[task 2021-11-24T15:18:18.489Z] 15:18:18    ERROR - Return code: 1
[task 2021-11-24T15:18:18.489Z] 15:18:18     INFO - TinderboxPrint: xpcshell-xpcshell<br/>1635/<em class="testfail">1</em>/4
[task 2021-11-24T15:18:18.489Z] 15:18:18  WARNING - # TBPL FAILURE #
[task 2021-11-24T15:18:18.489Z] 15:18:18  WARNING - setting return code to 2
[task 2021-11-24T15:18:18.489Z] 15:18:18  WARNING - The xpcshell suite: xpcshell ran with return status: FAILURE
[task 2021-11-24T15:18:18.490Z] 15:18:18     INFO - Running post-action listener: _package_coverage_data
[task 2021-11-24T15:18:18.490Z] 15:18:18     INFO - Running post-action listener: _resource_record_post_action
[task 2021-11-24T15:18:18.490Z] 15:18:18     INFO - Running post-action listener: process_java_coverage_data
[task 2021-11-24T15:18:18.490Z] 15:18:18     INFO - [mozharness: 2021-11-24 15:18:18.490183Z] Finished run-tests step (success)
[task 2021-11-24T15:18:18.490Z] 15:18:18     INFO - Running post-run listener: _resource_record_post_run
[task 2021-11-24T15:18:18.569Z] 15:18:18     INFO - instance_metadata.json not found; unable to determine instance type
[task 2021-11-24T15:18:18.570Z] 15:18:18     INFO - Validating Perfherder data against /opt/worker/tasks/task_163776500640799/mozharness/external_tools/performance-artifact-schema.json
[task 2021-11-24T15:18:18.573Z] 15:18:18     INFO - PERFHERDER_DATA: {"framework": {"name": "job_resource_usage"}, "suites": [{"name": "xpcshell.xpcshell.overall", "extraOptions": ["e10s", "buildbot-unknown"], "subtests": [{"name": "cpu_percent", "value": 35.46166666666667}, {"name": "io_write_bytes", "value": 9248833536}, {"name": "io.read_bytes", "value": 118824960}, {"name": "io_write_time", "value": 19908}, {"name": "io_read_time", "value": 5500}]}, {"name": "xpcshell.xpcshell.start-pulseaudio", "subtests": [{"name": "time", "value": 0.00043082237243652344}]}, {"name": "xpcshell.xpcshell.install", "subtests": [{"name": "time", "value": 27.838238954544067}, {"name": "cpu_percent", "value": 13.780128205128204}]}, {"name": "xpcshell.xpcshell.stage-files", "subtests": [{"name": "time", "value": 0.018421173095703125}]}, {"name": "xpcshell.xpcshell.run-tests", "subtests": [{"name": "time", "value": 297.0202012062073}, {"name": "cpu_percent", "value": 37.65445246690733}]}]}
[task 2021-11-24T15:18:18.573Z] 15:18:18     INFO - Total resource usage - Wall time: 324s; CPU: 38%; Read bytes: 118824960; Write bytes: 9248833536; Read time: 5500; Write time: 19908
[task 2021-11-24T15:18:18.573Z] 15:18:18     INFO - TinderboxPrint: CPU usage<br/>37.7%
[task 2021-11-24T15:18:18.573Z] 15:18:18     INFO - TinderboxPrint: I/O read bytes / time<br/>118,824,960 / 5,500
[task 2021-11-24T15:18:18.573Z] 15:18:18     INFO - TinderboxPrint: I/O write bytes / time<br/>9,248,833,536 / 19,908
[task 2021-11-24T15:18:18.573Z] 15:18:18     INFO - TinderboxPrint: CPU idle<br/>1,731.7 (44.6%)
[task 2021-11-24T15:18:18.573Z] 15:18:18     INFO - TinderboxPrint: CPU system<br/>518.8 (13.4%)
[task 2021-11-24T15:18:18.574Z] 15:18:18     INFO - TinderboxPrint: CPU user<br/>1,631.2 (42.0%)
[task 2021-11-24T15:18:18.574Z] 15:18:18     INFO - TinderboxPrint: Swap in / out<br/>406,228,992 / 0
[task 2021-11-24T15:18:18.574Z] 15:18:18     INFO - start-pulseaudio - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2021-11-24T15:18:18.574Z] 15:18:18     INFO - install - Wall time: 28s; CPU: 14%; Read bytes: 340473344; Write bytes: 326574080; Read time: 23945; Write time: 469
[task 2021-11-24T15:18:18.575Z] 15:18:18     INFO - stage-files - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2021-11-24T15:18:18.578Z] 15:18:18     INFO - run-tests - Wall time: 297s; CPU: 38%; Read bytes: 94031872; Write bytes: 8889577472; Read time: 4445; Write time: 19252
[task 2021-11-24T15:18:18.652Z] 15:18:18  WARNING - returning nonzero exit status 2
[taskcluster 2021-11-24T15:18:18.681Z]    Exit Code: 2
[taskcluster 2021-11-24T15:18:18.681Z]    User Time: 21m1.636106s
[taskcluster 2021-11-24T15:18:18.681Z]  Kernel Time: 6m27.289805s
[taskcluster 2021-11-24T15:18:18.681Z]    Wall Time: 6m57.222399s
[taskcluster 2021-11-24T15:18:18.681Z]       Result: FAILED
[taskcluster 2021-11-24T15:18:18.682Z] === Task Finished ===
[taskcluster 2021-11-24T15:18:18.682Z] Task Duration: 6m57.226625s
[taskcluster 2021-11-24T15:18:18.793Z] Uploading artifact public/logs/localconfig.json from file logs/localconfig.json with content encoding "gzip", mime type "application/json" and expiry 2021-12-22T13:44:50.220Z
[taskcluster 2021-11-24T15:18:19.031Z] Uploading artifact public/test_info/A1E4BC2A-9318-4C1D-8C41-F11E514AF7C1.dmp from file build/blobber_upload_dir/A1E4BC2A-9318-4C1D-8C41-F11E514AF7C1.dmp with content encoding "gzip", mime type "application/vnd.tcpdump.pcap" and expiry 2021-12-22T13:44:50.220Z
[taskcluster 2021-11-24T15:18:19.239Z] Uploading artifact public/test_info/A1E4BC2A-9318-4C1D-8C41-F11E514AF7C1.extra from file build/blobber_upload_dir/A1E4BC2A-9318-4C1D-8C41-F11E514AF7C1.extra with content encoding "gzip", mime type "application/octet-stream" and expiry 2021-12-22T13:44:50.220Z
[taskcluster 2021-11-24T15:18:19.374Z] Uploading artifact public/test_info/resource-usage.json from file build/blobber_upload_dir/resource-usage.json with content encoding "gzip", mime type "application/json" and expiry 2021-12-22T13:44:50.220Z
[taskcluster 2021-11-24T15:18:19.577Z] Uploading artifact public/test_info/system-info.log from file build/blobber_upload_dir/system-info.log with content encoding "gzip", mime type "text/plain" and expiry 2021-12-22T13:44:50.220Z
[taskcluster 2021-11-24T15:18:19.678Z] Uploading artifact public/test_info/xpcshell_errorsummary.log from file build/blobber_upload_dir/xpcshell_errorsummary.log with content encoding "gzip", mime type "text/plain" and expiry 2021-12-22T13:44:50.220Z
[taskcluster 2021-11-24T15:18:19.889Z] Uploading artifact public/test_info/xpcshell_raw.log from file build/blobber_upload_dir/xpcshell_raw.log with content encoding "gzip", mime type "text/plain" and expiry 2021-12-22T13:44:50.220Z
[taskcluster 2021-11-24T15:18:20.528Z] Uploading redirect artifact public/logs/live.log to URL https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/G5ksfH1ERpmC3fZRkedxhw/runs/0/artifacts/public%2Flogs%2Flive_backing.log with mime type "text/plain; charset=utf-8" and expiry 2021-12-22T13:44:50.220Z
[taskcluster:error] exit status 2

Hello, I couldn't find from which bug is this coming from.

The important line is this one:

[task 2021-11-24T15:18:18.167Z] 15:18:18  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature network.cookie.sameSite.laxByDefault should match runtime value. - false == true

It looks like bug 1617609 changed the pref to be on by default without updating the Feature Gate configuration.

Regressed by: samesitelax
Has Regression Range: --- → yes
Flags: needinfo?(ngogge)
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
Flags: needinfo?(ngogge)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/4c4fd44bf65a
adjust FeatureGate data: network.cookie.sameSite.* are 'true' across channels since the changes in bug 1617609. r=ckerschb,preferences-reviewers,ngogge

https://hg.mozilla.org/mozilla-central/rev/4c4fd44bf65a

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: