markPageAsFollowedLink should be called more reliably so places has accurate data
Categories
(Firefox :: Bookmarks & History, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | affected |
People
(Reporter: Gijs, Unassigned)
Details
In bug 1742801 I ran into the fact that apparently, for clicks on links we (or at least the automated test, browser_markPageAsFollowedLink.js) rely on the fact that the JS click handler actor gets invoked for link clicks in the child - even if we then decide in the parent actor not to do anything with the click because docshell itself will handle left mouse clicks with no modifier keys pressed. If we do the whereToOpenLink check in the child and don't broadcast it to the parent, the test starts failing.
Really, IMO all this code (ie handling modifier-clicks on links, as well as informing places about link clicks generally) should move to docshell/DOM, so it can more closely follow the spec. AIUI there should be docshell load flags indicating something was a link click, and we should be able to use those to indicate as much to places.
|
||
Comment 1•4 years ago
|
||
This is a valid concern and suggestions, thank you.
Description
•