1742915 - Cache tag object attribute

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

JAWS ignores semantics altogether when rendering buffers unless the tag object attribute is present.

I'm not sure how to best handle object attributes yet. I don't think we want a separate cache domain for every object attribute. We also don't want to cache some of the calculated attributes; e.g. posinset and setsize.

Comment 1

[James Teh [:Jamie]]

I just realised tag will never change, so it only needs to be included in the initial push.

Comment 2

[James Teh [:Jamie]]

In the CTW meeting, we agreed that most (but perhaps not all) object attributes would be flattened into mCachedFields. We will try to group them into several larger cache domains; e.g. DOM attributes. For attributes like tag that never change, we can just push them for the initial push regardless of cache domain.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1742915 part 1: Move Attributes to base Accessible.

The RemoteAccessibleBase implementation is a stub for now, but will be expanded in the next patch.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1742915 part 2: Cache the tag attribute.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1beb5cf0cceb
part 1: Move Attributes to base Accessible. r=morgan
https://hg.mozilla.org/integration/autoland/rev/587bbb6b9224
part 2: Cache the tag attribute. r=morgan

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c2905f3085a
Backed out 2 changesets for causing android bustages.

Comment 7

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1742915) for causing android bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/0c2905f3085a
Push with failures, failure log.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8644eb330d8a
part 1: Move Attributes to base Accessible. r=morgan
https://hg.mozilla.org/integration/autoland/rev/de58fa2ed2d5
part 2: Cache the tag attribute. r=morgan

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8644eb330d8a
https://hg.mozilla.org/mozilla-central/rev/de58fa2ed2d5